Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2977293002: Revert of Remove confusing keyboard test & focus on input device (Closed)

Created:
3 years, 5 months ago by Felix Ekblom
Modified:
3 years, 5 months ago
Reviewers:
jdufault, oshima
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, mnilsson
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove confusing keyboard test & focus on input device (patchset #9 id:160001 of https://codereview.chromium.org/2964823002/ ) Reason for revert: A follow up fix for a race condition on cold boot was reverted in https://chromium-review.googlesource.com/c/574731/. With only this patch the functionality is broken in the user facing scenario. The code state without either this cl or the follow up is better than with only this cl. Original issue's description: > Remove confusing keyboard test & inspect input device > > In order to make the decision for when to trigger the OOBE display > chooser less confusing for end users I'm removing the keyboard check. > Instead an explicit remora requisition check is used to limit the > effects. > > BUG=738885 > > Review-Url: https://codereview.chromium.org/2964823002 > Cr-Commit-Position: refs/heads/master@{#485019} > Committed: https://chromium.googlesource.com/chromium/src/+/c923b817665a649b4e18243116c31c68404af7dd TBR=jdufault@chromium.org,oshima@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=738885 Review-Url: https://codereview.chromium.org/2977293002 Cr-Commit-Position: refs/heads/master@{#487262} Committed: https://chromium.googlesource.com/chromium/src/+/8a2f3aa1eedac03d1fec4cccd802711424c39ce1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -103 lines) Patch
M chrome/browser/ui/webui/chromeos/login/oobe_display_chooser.cc View 3 chunks +11 lines, -21 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_display_chooser_unittest.cc View 3 chunks +41 lines, -75 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Felix Ekblom
Created Revert of Remove confusing keyboard test & focus on input device
3 years, 5 months ago (2017-07-17 21:23:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977293002/1
3 years, 5 months ago (2017-07-17 21:23:18 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-17 21:23:20 UTC) #5
jdufault
This is just a revert, right? lgtm in that case
3 years, 5 months ago (2017-07-17 21:23:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977293002/1
3 years, 5 months ago (2017-07-17 21:24:40 UTC) #8
Felix Ekblom
On 2017/07/17 21:23:57, jdufault wrote: > This is just a revert, right? lgtm in that ...
3 years, 5 months ago (2017-07-17 21:26:41 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 22:01:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8a2f3aa1eedac03d1fec4cccd802...

Powered by Google App Engine
This is Rietveld 408576698