Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: tracing/tracing/value/diagnostics/reserved_names.html

Issue 2977283002: Ownership into GenericSets (Closed)
Patch Set: Fix reserved info reference Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/value/diagnostics/reserved_names.html
diff --git a/tracing/tracing/value/diagnostics/reserved_names.html b/tracing/tracing/value/diagnostics/reserved_names.html
index 5875f5e2eac1b0e6c6e50c1dc6e871bd5dfad525..7d65d7b2c561f3fffcb7e3ee1dce80e1b7326506 100644
--- a/tracing/tracing/value/diagnostics/reserved_names.html
+++ b/tracing/tracing/value/diagnostics/reserved_names.html
@@ -33,11 +33,12 @@ tr.exportTo('tr.v.d', function() {
LABELS: {name: 'labels', type: tr.v.d.GenericSet},
LOG_URLS: {name: 'log urls', type: tr.v.d.GenericSet},
MASTERS: {name: 'masters', type: tr.v.d.GenericSet},
- MEMORY_AMOUNTS: {name: 'memory amounts', type: tr.v.d.GenericSet},
benjhayden 2017/07/17 22:08:06 Why did this change?
+ MEMORY: {name: 'memory', type: tr.v.d.GenericSet},
MERGED_FROM: {name: 'merged from', type: tr.v.d.RelatedHistogramSet},
MERGED_TO: {name: 'merged to', type: tr.v.d.RelatedHistogramSet},
- OS_NAMES: {name: 'os names', type: tr.v.d.GenericSet},
benjhayden 2017/07/17 22:08:06 Why did this change?
+ OS: {name: 'os', type: tr.v.d.GenericSet},
OS_VERSIONS: {name: 'os versions', type: tr.v.d.GenericSet},
+ OWNERS: {name: 'owners', type: tr.v.d.GenericSet},
PRODUCT_VERSIONS: {name: 'product versions', type: tr.v.d.GenericSet},
RELATED_NAMES: {name: 'related names', type: tr.v.d.GenericSet},
SKIA_REVISIONS: {name: 'skia revisions', type: tr.v.d.GenericSet},
@@ -45,7 +46,7 @@ tr.exportTo('tr.v.d', function() {
STORYSET_REPEATS: {name: 'storyset repeats', type: tr.v.d.GenericSet},
STORY_TAGS: {name: 'story tags', type: tr.v.d.GenericSet},
TAG_MAP: {name: 'tagmap', type: tr.v.d.TagMap},
- TRACE_START: {name: 'trace start', type: tr.v.d.DateRange},
benjhayden 2017/07/17 22:08:06 Why did this change?
+ TRACE_STARTS: {name: 'trace starts', type: tr.v.d.DateRange},
TRACE_URLS: {name: 'trace urls', type: tr.v.d.GenericSet},
V8_COMMIT_POSITIONS: {name: 'v8 commit positions', type: tr.v.d.DateRange},
V8_REVISIONS: {name: 'v8 revisions', type: tr.v.d.GenericSet},
@@ -58,9 +59,6 @@ tr.exportTo('tr.v.d', function() {
ITERATION: {name: 'iteration'}, // Legacy name for TELEMETRY
REVISIONS: {name: 'revisions'}, // RevisionInfo or MergedRevisionInfo
TELEMETRY: {name: 'telemetry'}, // TelemetryInfo or MergedTelemetryInfo
-
- // TODO(#3507) Change OWNERS to GenericSet of email addresses.
- OWNERS: {name: 'owners', type: tr.v.d.Ownership},
};
const RESERVED_NAMES = {};

Powered by Google App Engine
This is Rietveld 408576698