Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: telemetry/telemetry/internal/story_runner.py

Issue 2977283002: Ownership into GenericSets (Closed)
Patch Set: Fix reserved info reference Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« telemetry/telemetry/benchmark_unittest.py ('K') | « telemetry/telemetry/benchmark_unittest.py ('k') | telemetry/telemetry/internal/story_runner_unittest.py » ('j') | tracing/tracing/value/diagnostics/reserved_names.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/internal/story_runner.py
diff --git a/telemetry/telemetry/internal/story_runner.py b/telemetry/telemetry/internal/story_runner.py
index 20ce07a52748d84e5d1cb116da03dfb867130850..d2f9342f761b21489d3cf0c309e4fa4f7ea2c2c7 100644
--- a/telemetry/telemetry/internal/story_runner.py
+++ b/telemetry/telemetry/internal/story_runner.py
@@ -407,7 +407,10 @@ def RunBenchmark(benchmark, finder_options):
return_code = 255
results.histograms.AddSharedDiagnostic(
benjhayden 2017/07/17 22:08:06 Why not elide these diagnostics if they are empty?
- reserved_infos.OWNERS.name, benchmark.GetOwnership())
+ reserved_infos.OWNERS.name, benchmark.GetOwners())
+
+ results.histograms.AddSharedDiagnostic(
+ reserved_infos.BUG_COMPONENTS.name, benchmark.GetComponent())
try:
if finder_options.upload_results:
« telemetry/telemetry/benchmark_unittest.py ('K') | « telemetry/telemetry/benchmark_unittest.py ('k') | telemetry/telemetry/internal/story_runner_unittest.py » ('j') | tracing/tracing/value/diagnostics/reserved_names.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698