Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2977273002:
Promote fixed: position elements with composited descendants even if they don't scroll (Closed)
|
Created:
3 years, 5 months ago by smcgruer Modified:
3 years, 5 months ago CC:
amineer, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionPromote fixed: position elements with composited descendants even if they don't scroll
This is effectively a partial revert of
9b503962a017a8d69adfdae9300684c299922640 done manually to avoid
reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary
for sticky elements.
Bug=742213
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2977273002
Cr-Commit-Position: refs/heads/master@{#487281}
Committed: https://chromium.googlesource.com/chromium/src/+/6fd45a36bc17130770e99cb04cf82dfc15659812
Patch Set 1 #
Messages
Total messages: 20 (13 generated)
Description was changed from ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug: 742213 ========== to ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug: 742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug: 742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a partial revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug: 742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was checked by smcgruer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a partial revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug: 742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a partial revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug=742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
smcgruer@chromium.org changed reviewers: + flackr@chromium.org
smcgruer@chromium.org changed reviewers: + chrishtr@chromium.org, pdr@google.com, schenney@google.com
Hey Stephen, Philip, Chris, This is a partial revert CL for a M60 stable blocking regression (http://crbug.com/742213). I was intending to wait until tomorrow to get flackr's LGTM, but release eng are asking for it to go in tonight so that it can soak in Canary overnight before a merge back to M60. The idea of this CL is to just bring us back to the pre- http://crrev.com/9b5039 behavior for position: fixed elements, i.e. promote them if they have any composited descendants. I then plan on hunting down the underlying bug that caused the regression, fixing it, and reverting this in the future. Thanks for reviewing! Stephen
Oh and I will be around this evening so feel free to ping me if you have questions/concerns :)
LGTM
lgtm
The CQ bit was checked by smcgruer@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1500330491976800, "parent_rev":
"3254916b08956baf8288b43e82096aadb93b2052", "commit_rev":
"dd9efc8fb1febe8d08a1b8063f8a233c18bc37d5"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1500330491976800, "parent_rev":
"559b70dee308e0a3fd683119650fe8f5ee0cbfdb", "commit_rev":
"6fd45a36bc17130770e99cb04cf82dfc15659812"}
Message was sent while issue was closed.
Description was changed from ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a partial revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug=742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Promote fixed: position elements with composited descendants even if they don't scroll This is effectively a partial revert of 9b503962a017a8d69adfdae9300684c299922640 done manually to avoid reverting de4c11424c87b46a8f5ce0935f9367a868baa507 which is necessary for sticky elements. Bug=742213 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2977273002 Cr-Commit-Position: refs/heads/master@{#487281} Committed: https://chromium.googlesource.com/chromium/src/+/6fd45a36bc17130770e99cb04cf8... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6fd45a36bc17130770e99cb04cf8... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
