Issue 2977223002: Update the homebrew recipe to not have Dartium dev versions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2977223002: Update the homebrew recipe to not have Dartium dev versions. (Closed)

Created:
3 years, 5 months ago by Bill Hesse

Modified:
3 years, 5 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Update the homebrew recipe to not have Dartium dev versions. BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/sdk/commit/7643dc86fc4b837f743c7131dd6e669b8c53a7e3

Patch Set 1 #

Total comments: 1

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -15 lines)			Patch
	M	tools/apps/update_homebrew/lib/update_homebrew.dart	View		3 chunks	+6 lines, -15 lines	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

kevmoo

LGTM https://codereview.chromium.org/2977223002/diff/1/tools/apps/update_homebrew/lib/update_homebrew.dart File tools/apps/update_homebrew/lib/update_homebrew.dart (right): https://codereview.chromium.org/2977223002/diff/1/tools/apps/update_homebrew/lib/update_homebrew.dart#newcode140 tools/apps/update_homebrew/lib/update_homebrew.dart:140: option "with-dartium", "Download and install Dartium -- Chromium ...

3 years, 5 months ago (2017-07-17 16:25:47 UTC) #3

Bill Hesse

3 years, 5 months ago (2017-07-17 16:31:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7643dc86fc4b837f743c7131dd6e669b8c53a7e3 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages