Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: tools/apps/update_homebrew/lib/update_homebrew.dart

Issue 2977223002: Update the homebrew recipe to not have Dartium dev versions. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/apps/update_homebrew/lib/update_homebrew.dart
diff --git a/tools/apps/update_homebrew/lib/update_homebrew.dart b/tools/apps/update_homebrew/lib/update_homebrew.dart
index 887083f91a46e7f1983c759e028c24888247c2ee..49e8da790cc57466bd6b570feb0bf668a54331b5 100644
--- a/tools/apps/update_homebrew/lib/update_homebrew.dart
+++ b/tools/apps/update_homebrew/lib/update_homebrew.dart
@@ -11,7 +11,10 @@ const GITHUB_REPO = 'dart-lang/homebrew-dart';
const CHANNELS = const ['dev', 'stable'];
-const FILES = const [x64File, ia32File, dartiumFile, contentShellFile];
+const FILES = const {
+ 'dev': const [x64File, ia32File],
+ 'stable': const [x64File, ia32File, dartiumFile, contentShellFile]
+};
const urlBase = 'https://storage.googleapis.com/dart-archive/channels';
const x64File = 'sdk/dartsdk-macos-x64-release.zip';
@@ -79,7 +82,7 @@ Future<Map> getHashes(Map revisions) async {
var hashes = <String, Map>{};
for (var channel in CHANNELS) {
hashes[channel] = {};
- for (var file in FILES) {
+ for (var file in FILES[channel]) {
var hash = await getHash256(channel, revisions[channel], file);
hashes[channel][file] = hash;
}
@@ -131,22 +134,10 @@ class Dart < Formula
url "$urlBase/dev/release/${revisions['dev']}/$ia32File"
sha256 "${hashes['dev'][ia32File]}"
end
-
- resource "content_shell" do
- version "$devVersion"
- url "$urlBase/dev/release/${revisions['dev']}/$contentShellFile"
- sha256 "${hashes['dev'][contentShellFile]}"
- end
-
- resource "dartium" do
- version "$devVersion"
- url "$urlBase/dev/release/${revisions['dev']}/$dartiumFile"
- sha256 "${hashes['dev'][dartiumFile]}"
- end
end
option "with-content-shell", "Download and install content_shell -- headless Dartium for testing"
- option "with-dartium", "Download and install Dartium -- Chromium with Dar"
+ option "with-dartium", "Download and install Dartium -- Chromium with Dart"
kevmoo 2017/07/17 16:25:47 Good find! :-)
resource "content_shell" do
version "$stableVersion"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698