Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2977173002: [milo] add milo version to page base (Closed)

Created:
3 years, 5 months ago by iannucci
Modified:
3 years, 5 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -27 lines) Patch
M milo/frontend/appengine/templates/includes/base.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/buildbot.build-Debug_page-_CrWinGoma_30608.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/buildbot.build-Debug_page-_chromium_presubmit_426944.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/buildbot.build-Debug_page-_gerritCL_1234.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/buildbot.build-Debug_page-_newline_1234.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/buildbot.build-Debug_page-_win_chromium_rel_ng_246309.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/buildbot.builder-Basic_Test_no_builds.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/buildbot.builder-Basic_Test_with_builds.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/frontpage-Basic_frontpage.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-Basic_successful_build.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-canceled.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-exception.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-expired.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-finished-logdog-expired-stream.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-gerrit.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-internal.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-link.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-nested.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-patch-failure.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-pending.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-pending-logdog.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-running.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-running-logdog.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-running-logdog-no-annotation-stream.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-timeout.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.build-build-unicode.html View 1 chunk +2 lines, -1 line 0 comments Download
M milo/frontend/expectations/swarming.log-Basic_log.html View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
iannucci
3 years, 5 months ago (2017-07-14 23:06:42 UTC) #1
Ryan Tseng
lgtm
3 years, 5 months ago (2017-07-14 23:08:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977173002/1
3 years, 5 months ago (2017-07-14 23:13:30 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 23:18:08 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/28c337759ad370a18bc087902b4a497b3599a798

Powered by Google App Engine
This is Rietveld 408576698