Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2977083002: Move gitiles module from milo to common/api. (Closed)

Created:
3 years, 5 months ago by tandrii(chromium)
Modified:
3 years, 5 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Move gitiles module from milo to common/api. I'll be improving it and making use of it in scheduler. R=iannucci@chromium.org Bug: 646067 Review-Url: https://codereview.chromium.org/2977083002 Committed: https://github.com/luci/luci-go/commit/915ce57f5cd2262f6324a5af4bf7643f566e1dea

Patch Set 1 #

Total comments: 1

Patch Set 2 : docnit #

Total comments: 2

Patch Set 3 : -comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -166 lines) Patch
A common/api/gitiles/doc.go View 1 chunk +16 lines, -0 lines 0 comments Download
A + common/api/gitiles/gitiles.go View 1 5 chunks +14 lines, -37 lines 0 comments Download
D milo/common/gitiles/gitiles.go View 1 chunk +0 lines, -127 lines 0 comments Download
M milo/frontend/console/console.go View 1 2 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tandrii(chromium)
ptal https://codereview.chromium.org/2977083002/diff/1/common/api/gitiles/gitiles.go File common/api/gitiles/gitiles.go (left): https://codereview.chromium.org/2977083002/diff/1/common/api/gitiles/gitiles.go#oldcode30 common/api/gitiles/gitiles.go:30: type Repo struct { this was unused, and ...
3 years, 5 months ago (2017-07-13 20:51:38 UTC) #5
iannucci
lgtm https://codereview.chromium.org/2977083002/diff/20001/milo/frontend/console/console.go File milo/frontend/console/console.go (right): https://codereview.chromium.org/2977083002/diff/20001/milo/frontend/console/console.go#newcode129 milo/frontend/console/console.go:129: // Move things into our own datastructure. comment ...
3 years, 5 months ago (2017-07-13 21:23:27 UTC) #8
tandrii(chromium)
https://codereview.chromium.org/2977083002/diff/20001/milo/frontend/console/console.go File milo/frontend/console/console.go (right): https://codereview.chromium.org/2977083002/diff/20001/milo/frontend/console/console.go#newcode129 milo/frontend/console/console.go:129: // Move things into our own datastructure. On 2017/07/13 ...
3 years, 5 months ago (2017-07-14 10:13:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977083002/40001
3 years, 5 months ago (2017-07-14 10:14:18 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 10:19:56 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/915ce57f5cd2262f6324a5af4bf7643f566e1dea

Powered by Google App Engine
This is Rietveld 408576698