Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2977043002: Refactor: Moving CrOS-specific service registration code (Closed)

Created:
3 years, 5 months ago by mfomitchev
Modified:
3 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor: Moving CrOS-specific service registration code Creating RegisterInProcessServices() in BrowserProcessPlatformPart, and moving the CrOS-specific service registration code from ChromeContentBrowserClient to CrOS BrowserProcessPlatformPart. BUG=722527 Review-Url: https://codereview.chromium.org/2977043002 Cr-Commit-Position: refs/heads/master@{#486520} Committed: https://chromium.googlesource.com/chromium/src/+/220b856a5608489f219a74ff47455f0994838960

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Removing unneeded dependency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -123 lines) Patch
M chrome/browser/browser_process_platform_part_base.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_platform_part_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browser_process_platform_part_chromeos.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/browser_process_platform_part_chromeos.cc View 3 chunks +121 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 9 chunks +2 lines, -121 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
mfomitchev
3 years, 5 months ago (2017-07-13 14:16:13 UTC) #6
sky
Nice refactoring to move platform specific code where it belongs. LGTM
3 years, 5 months ago (2017-07-13 17:21:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977043002/40001
3 years, 5 months ago (2017-07-13 18:54:09 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/337873)
3 years, 5 months ago (2017-07-13 20:01:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977043002/40001
3 years, 5 months ago (2017-07-13 20:04:10 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 23:09:40 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/220b856a5608489f219a74ff4745...

Powered by Google App Engine
This is Rietveld 408576698