Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2977023002: Revert of Fixes redirects to external apps when navigating from PWA. (Closed)

Created:
3 years, 5 months ago by aberent
Modified:
3 years, 5 months ago
Reviewers:
dominickn, Ted C, Yusuf, piotrs
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixes redirects to external apps when navigating from PWA. (patchset #10 id:300001 of https://codereview.chromium.org/2969143002/ ) Reason for revert: Still failing on Marshmallow 64 bit Tester. See, for example https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/13798 BUG=741568 Original issue's description: > Fixes the redirect to external apps when navigating from PWA. > > This is done with avoiding explicit chrome package name (using > component name instead) and using > EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent. > > With this patch the redirect works, however it takes a long time for CCT to > consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect > in ChromeTabbedActivity is almost instantaneous. Result is that > for _blank links CCT shows up briefly before redirecting to an external app. > In a follow up it should be investigated why it is the case and if it cannot > be improved, we might need to bypass CCT in such case, which would diverge > from existing navigation paths for _blank links in Clank. > > BUG=740402 > > Review-Url: https://codereview.chromium.org/2969143002 > Cr-Original-Commit-Position: refs/heads/master@{#485831} > Committed: https://chromium.googlesource.com/chromium/src/+/727468b41b2fe48bf73983ab0c3aa2632b47d89e > Review-Url: https://codereview.chromium.org/2969143002 > Cr-Commit-Position: refs/heads/master@{#486275} > Committed: https://chromium.googlesource.com/chromium/src/+/4dbcecfb630ac1a2dba1910f0e429b82bf3a0b5f TBR=dominickn@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,piotrs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=740402 Review-Url: https://codereview.chromium.org/2977023002 Cr-Commit-Position: refs/heads/master@{#486333} Committed: https://chromium.googlesource.com/chromium/src/+/b2fa8274b92136d9dd2d347b6e33b4e56bfe21f7

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
aberent
Created Revert of Fixes redirects to external apps when navigating from PWA.
3 years, 5 months ago (2017-07-13 10:17:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2977023002/1
3 years, 5 months ago (2017-07-13 10:17:51 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 10:18:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b2fa8274b92136d9dd2d347b6e33...

Powered by Google App Engine
This is Rietveld 408576698