Report messages instead of just printing.

pkg/front_end/lib/src/kernel_generator_impl.dart

Index: pkg/front_end/lib/src/kernel_generator_impl.dart
diff --git a/pkg/front_end/lib/src/kernel_generator_impl.dart b/pkg/front_end/lib/src/kernel_generator_impl.dart
index 2116a4954cab6eb2b03c28f9174b672f3953d0e6..c7b639571e0fadc5949a7ea2171ceb579c255437 100644
--- a/pkg/front_end/lib/src/kernel_generator_impl.dart
+++ b/pkg/front_end/lib/src/kernel_generator_impl.dart
@@ -15,6 +15,7 @@ import 'fasta/compiler_command_line.dart' show CompilerCommandLine;
 import 'fasta/compiler_context.dart' show CompilerContext;
 import 'fasta/deprecated_problems.dart' show deprecated_InputError, reportCrash;
 import 'fasta/dill/dill_target.dart' show DillTarget;
+import 'fasta/fasta_codes.dart' show LocatedMessage;
 import 'fasta/kernel/kernel_outline_shaker.dart';
 import 'fasta/kernel/kernel_target.dart' show KernelTarget;
 import 'fasta/kernel/utils.dart';
@@ -147,7 +148,10 @@ Future<CompilerResult> generateKernelInternal(ProcessedOptions options,
     }
 
     if (kernelTarget.errors.isNotEmpty) {
-      kernelTarget.errors.forEach(options.deprecated_reportError);
+      // TODO(ahe): The errors have already been reported via CompilerContext.
+      for (LocatedMessage message in kernelTarget.errors) {

[Siggi Cherem (dart-lang), 2017/07/13 21:05:56]

irrelevant style question: why not
`kernelTarget.errors.forEach(options.reportMessage)`?

Agree though, this should go away once we integrate context.report with
options.reportMessage

[ahe, 2017/07/14 10:01:07]

This is a mistake because of how this code evolved in my local branch. At some
point in this code's history, I didn't have a function to conveniently pass to
forEach.

+        options.reportMessage(message);
+      }
       return null;
     }
 
@@ -156,7 +160,7 @@ Future<CompilerResult> generateKernelInternal(ProcessedOptions options,
         program: program,
         deps: kernelTarget.loader.getDependencies());
   } on deprecated_InputError catch (e) {
-    options.deprecated_reportError(e.deprecated_format());
+    options.reportMessage(deprecated_InputError.toMessage(e));
     return null;
   } catch (e, t) {
     return reportCrash(e, t);