Report messages instead of just printing.

pkg/front_end/lib/src/kernel_generator_impl.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Defines the front-end API for converting source code to Dart Kernel objects.
 library front_end.kernel_generator_impl;
 
 import 'dart:async' show Future;
 import 'dart:async';
 
 import 'package:kernel/kernel.dart' show Program, CanonicalName;
 
 import 'base/processed_options.dart';
 import 'fasta/compiler_command_line.dart' show CompilerCommandLine;
 import 'fasta/compiler_context.dart' show CompilerContext;
 import 'fasta/deprecated_problems.dart' show deprecated_InputError, reportCrash;
 import 'fasta/dill/dill_target.dart' show DillTarget;
+import 'fasta/fasta_codes.dart' show LocatedMessage;
 import 'fasta/kernel/kernel_outline_shaker.dart';
 import 'fasta/kernel/kernel_target.dart' show KernelTarget;
 import 'fasta/kernel/utils.dart';
 import 'fasta/kernel/verifier.dart';
 import 'fasta/uri_translator.dart' show UriTranslator;
 
 /// Implementation for the `package:front_end/kernel_generator.dart` and
 /// `package:front_end/summary_generator.dart` APIs.
 Future<CompilerResult> generateKernel(ProcessedOptions options,
     {bool buildSummary: false,
@@ skipping 112 matching lines @@
             dillTarget.loader.libraries.map((lib) => lib.importUri).toSet();
         trimProgram(program, (uri) => !excluded.contains(uri));
       }
       if (options.debugDump) {
         printProgramText(program, libraryFilter: kernelTarget.isSourceLibrary);
       }
       options.ticker.logMs("Generated program");
     }
 
     if (kernelTarget.errors.isNotEmpty) {
-      kernelTarget.errors.forEach(options.deprecated_reportError);
+      // TODO(ahe): The errors have already been reported via CompilerContext.
+      for (LocatedMessage message in kernelTarget.errors) {

[Siggi Cherem (dart-lang), 2017/07/13 21:05:56]

irrelevant style question: why not
`kernelTarget.errors.forEach(options.reportMessage)`?

Agree though, this should go away once we integrate context.report with
options.reportMessage

[ahe, 2017/07/14 10:01:07]

This is a mistake because of how this code evolved in my local branch. At some
point in this code's history, I didn't have a function to conveniently pass to
forEach.

+        options.reportMessage(message);
+      }
       return null;
     }
 
     return new CompilerResult(
         summary: summary,
         program: program,
         deps: kernelTarget.loader.getDependencies());
   } on deprecated_InputError catch (e) {
-    options.deprecated_reportError(e.deprecated_format());
+    options.reportMessage(deprecated_InputError.toMessage(e));
     return null;
   } catch (e, t) {
     return reportCrash(e, t);
   }
 }
 
 /// Result object of [generateKernel].
 class CompilerResult {
   /// The generated summary bytes, if it was requested.
   final List<int> summary;
 
   /// The generated program, if it was requested.
   final Program program;
 
   /// Dependencies traversed by the compiler. Used only for generating
   /// dependency .GN files in the dart-sdk build system.
   /// Note this might be removed when we switch to compute depencencies without
   /// using the compiler itself.
   final List<Uri> deps;
 
   CompilerResult({this.summary, this.program, this.deps});
 }