Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 297693002: Tests for "WebView: speed up user gesture notification for GestureTap" (Closed)

Created:
6 years, 7 months ago by vabr (Chromium)
Modified:
6 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+watchlist_chromium.org, Patrick Dubroy
Visibility:
Public.

Description

Tests for "WebView: speed up user gesture notification for GestureTap" This provides a test for a Blink fix at https://codereview.chromium.org/288423002/ The test copies exactly the reproduction steps from http://crbug.com/372595: 1. Saves credentials for a form. 2. Reloads the form, letting the credentials be autocompleted. 3. As the very first user interaction, taps on the submit button. 4. Checks that the autofilled password was correctly submitted. The test could not be done in Blink, because it relies on password autocompletion. BUG=372595 R=phajdan.jr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272188

Patch Set 1 #

Patch Set 2 : Limit test to Aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -2 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 2 chunks +35 lines, -0 lines 0 comments Download
M chrome/test/data/password/form_and_link.html View 1 chunk +16 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
vabr (Chromium)
Hi Paweł, Could you please review this CL? I mainly need an OWNERS approval from ...
6 years, 7 months ago (2014-05-20 12:01:23 UTC) #1
Paweł Hajdan Jr.
LGTM
6 years, 7 months ago (2014-05-20 12:43:34 UTC) #2
vabr (Chromium)
Thanks! The two trybots failing so far had too old revision, anything after 271668 (Blink ...
6 years, 7 months ago (2014-05-20 17:27:07 UTC) #3
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 7 months ago (2014-05-20 17:27:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/297693002/1
6 years, 7 months ago (2014-05-20 17:28:43 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 19:09:32 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-21 00:47:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/30720)
6 years, 7 months ago (2014-05-21 00:47:54 UTC) #8
vabr (Chromium)
FYI: Update on patch set 2 and the failed Mac test Mac failure was due ...
6 years, 7 months ago (2014-05-21 14:07:28 UTC) #9
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 7 months ago (2014-05-21 14:07:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/297693002/20001
6 years, 7 months ago (2014-05-21 19:56:52 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 07:51:58 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 13:38:34 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9770)
6 years, 7 months ago (2014-05-22 13:38:35 UTC) #14
vabr (Chromium)
The CQ bit was checked by vabr@chromium.org
6 years, 7 months ago (2014-05-22 13:50:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/297693002/20001
6 years, 7 months ago (2014-05-22 13:50:47 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 13:54:07 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 13:56:21 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9770)
6 years, 7 months ago (2014-05-22 13:56:22 UTC) #19
vabr (Chromium)
6 years, 7 months ago (2014-05-22 15:13:32 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 manually as r272188 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698