Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2976923002: Remove GPU service dependency on services/ui/common. (Closed)

Created:
3 years, 5 months ago by mfomitchev
Modified:
3 years, 5 months ago
Reviewers:
sadrul
CC:
chromium-reviews, rjkroege, blundell+services-watchlist_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GPU service dependency on services/ui/common. All of that code is UI Service specific. There's no reason GPU Service should depend on it. Before this change, services/ui/common was getting pulled into Mac and Android builds. BUG=NONE Review-Url: https://codereview.chromium.org/2976923002 Cr-Commit-Position: refs/heads/master@{#486234} Committed: https://chromium.googlesource.com/chromium/src/+/75f2bf5d98a57f1fe65cee27327ff9b8680f81f7

Patch Set 1 #

Patch Set 2 : Adding a DEPS rule as well. #

Patch Set 3 : Removing +services/ui/common from services/ui/gpu/DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M services/ui/gpu/DEPS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/public/cpp/gpu/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A services/ui/public/cpp/gpu/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
mfomitchev
3 years, 5 months ago (2017-07-12 23:53:41 UTC) #6
sadrul
Can you also remove from services/ui/gpu/DEPS? lgtm
3 years, 5 months ago (2017-07-13 00:06:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976923002/40001
3 years, 5 months ago (2017-07-13 00:30:36 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 02:43:21 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/75f2bf5d98a57f1fe65cee27327f...

Powered by Google App Engine
This is Rietveld 408576698