Added a nested class to gfx::Animation

Added a nested class to gfx::Animation

The new class is a reimplementation of SlideAnimation::TestApi which
allows tests to manipulate animations.

BUG=741076
Review-Url: https://codereview.chromium.org/2976873003
Cr-Commit-Position: refs/heads/master@{#486887}
Committed: https://chromium.googlesource.com/chromium/src/+/fe6f35b2483e35bcd3e8c775b6810eab2e1e3be3

[newcomer, 2017-07-12 17:01:34]

Description was changed from

==========
Added a nested class to gfx::Animation

The new class is a reimplementation of SlideAnimation::TestApi which
allows tests to manipulate animations.

BUG=741076
==========

to

==========
Added a nested class to gfx::Animation

The new class is a reimplementation of SlideAnimation::TestApi which
allows tests to manipulate animations.

BUG=741076
==========

[newcomer, 2017-07-12 17:01:35]

newcomer@chromium.org changed reviewers:
+ sky@chromium.org

[newcomer, 2017-07-12 17:02:09]

Sky,

PTAL.

-Alex

[sky, 2017-07-12 19:16:19]

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/BUILD.gn
File ui/gfx/animation/BUILD.gn (right):

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/BUILD.gn#n...
ui/gfx/animation/BUILD.gn:25: "animations_test_api.h",
You have a misspelling here. Also, the test files should be in a test only
target (not compiled in the real product).

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation.h
File ui/gfx/animation/animation.h (right):

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation....
ui/gfx/animation/animation.h:72: class AnimationTestApi;
Make this a top-level class (not inside Animation).

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation_...
File ui/gfx/animation/animation_test_api.cc (right):

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation_...
ui/gfx/animation/animation_test_api.cc:7: #include "base/macros.h"
This include should be in the header.

[sky, 2017-07-12 22:42:36]

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/BUILD.gn
File ui/gfx/animation/BUILD.gn (right):

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/BUILD.gn#n...
ui/gfx/animation/BUILD.gn:25: "animations_test_api.h",
On 2017/07/12 19:16:19, sky wrote:
> You have a misspelling here. Also, the test files should be in a test only
> target (not compiled in the real product).

Put them in ui/gfx:test_support.

[newcomer, 2017-07-13 20:36:34]

Patchset #2 (id:20001) has been deleted

[newcomer, 2017-07-13 20:39:10]

Patchset #2 (id:40001) has been deleted

[newcomer, 2017-07-13 21:17:48]

Patchset #2 (id:60001) has been deleted

[newcomer, 2017-07-13 21:19:28]

Sky,
Thanks for the feedback! 
-Alex

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/BUILD.gn
File ui/gfx/animation/BUILD.gn (right):

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/BUILD.gn#n...
ui/gfx/animation/BUILD.gn:25: "animations_test_api.h",
On 2017/07/12 19:16:19, sky wrote:
> You have a misspelling here. Also, the test files should be in a test only
> target (not compiled in the real product).

Acknowledged.

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/BUILD.gn#n...
ui/gfx/animation/BUILD.gn:25: "animations_test_api.h",
On 2017/07/12 22:42:36, sky wrote:
> On 2017/07/12 19:16:19, sky wrote:
> > You have a misspelling here. Also, the test files should be in a test only
> > target (not compiled in the real product).
> 
> Put them in ui/gfx:test_support.

Done.

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation.h
File ui/gfx/animation/animation.h (right):

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation....
ui/gfx/animation/animation.h:72: class AnimationTestApi;
On 2017/07/12 19:16:19, sky wrote:
> Make this a top-level class (not inside Animation).

Done.

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation_...
File ui/gfx/animation/animation_test_api.cc (right):

https://codereview.chromium.org/2976873003/diff/1/ui/gfx/animation/animation_...
ui/gfx/animation/animation_test_api.cc:7: #include "base/macros.h"
On 2017/07/12 19:16:19, sky wrote:
> This include should be in the header.

Done.

[sky, 2017-07-13 23:14:05]

LGTM

https://codereview.chromium.org/2976873003/diff/80001/ui/gfx/animation/animat...
File ui/gfx/animation/animation_test_api.h (right):

https://codereview.chromium.org/2976873003/diff/80001/ui/gfx/animation/animat...
ui/gfx/animation/animation_test_api.h:1: // Copyright (c) 2017 The Chromium
Authors. All rights reserved.
no (c) (see style guide).

[newcomer, 2017-07-13 23:18:59]

The CQ bit was checked by newcomer@chromium.org to run a CQ dry run

[newcomer, 2017-07-13 23:19:02]

The CQ bit was unchecked by newcomer@chromium.org

[newcomer, 2017-07-13 23:19:03]

The CQ bit was checked by newcomer@chromium.org

[newcomer, 2017-07-13 23:19:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2976873003/#ps100001
(title: "Responded to comments")

[newcomer, 2017-07-13 23:19:08]

The CQ bit was checked by newcomer@chromium.org

[commit-bot: I haz the power, 2017-07-13 23:19:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 00:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 00:16:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[newcomer, 2017-07-14 17:01:48]

The CQ bit was checked by newcomer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-14 17:02:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 18:56:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-14 18:56:59]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[newcomer, 2017-07-14 20:18:15]

The CQ bit was checked by newcomer@chromium.org

[newcomer, 2017-07-14 20:18:15]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2976873003/#ps120001
(title: "Removed animation export macro.")

[commit-bot: I haz the power, 2017-07-14 20:18:31]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-14 21:06:43]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1500063495381320,
"parent_rev": "edc090649966c37e060d073addca425382dc4e38", "commit_rev":
"fe6f35b2483e35bcd3e8c775b6810eab2e1e3be3"}

[commit-bot: I haz the power, 2017-07-14 21:07:04]

Description was changed from

==========
Added a nested class to gfx::Animation

The new class is a reimplementation of SlideAnimation::TestApi which
allows tests to manipulate animations.

BUG=741076
==========

to

==========
Added a nested class to gfx::Animation

The new class is a reimplementation of SlideAnimation::TestApi which
allows tests to manipulate animations.

BUG=741076

Review-Url: https://codereview.chromium.org/2976873003
Cr-Commit-Position: refs/heads/master@{#486887}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe6f35b2483e35bcd3e8c775b681...
==========

[commit-bot: I haz the power, 2017-07-14 21:07:06]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/fe6f35b2483e35bcd3e8c775b681...

[newcomer, 2017-07-17 14:54:32]

https://codereview.chromium.org/2976873003/diff/80001/ui/gfx/animation/animat...
File ui/gfx/animation/animation_test_api.h (right):

https://codereview.chromium.org/2976873003/diff/80001/ui/gfx/animation/animat...
ui/gfx/animation/animation_test_api.h:1: // Copyright (c) 2017 The Chromium
Authors. All rights reserved.
On 2017/07/13 23:14:05, sky wrote:
> no (c) (see style guide).

Done.