Issue 297683005: android: add Java-side support for browser compositor async readback

Issue 297683005: android: add Java-side support for browser compositor async readback (Closed)

Created:
6 years, 7 months ago by powei

Modified:
6 years, 7 months ago

Reviewers:
Ted C, no sievers

CC:
chromium-reviews, darin-cc_chromium.org, jam, danakj

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

android: add Java-side support for browser compositor async readback The android browser compositor removed support for sync readback. Support for async readback was added (https://codereview.chromium.org/281003002/). This patch adds a Java-side API through the existing ContentReadbackHandler. android= https://chrome-internal-review.googlesource.com/#/c/164043/ BUG=252046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273026

Patch Set 3 : addressed tedchoc comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -112 lines)			Patch
M	content/browser/android/content_readback_handler.h	View	1 2	2 chunks	+11 lines, -3 lines	0 comments	Download
M	content/browser/android/content_readback_handler.cc	View	1 2	3 chunks	+66 lines, -17 lines	0 comments	Download
M	content/browser/renderer_host/compositor_impl_android.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/compositor_impl_android.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java	View	1 2	6 chunks	+33 lines, -11 lines	0 comments	Download
M	content/public/browser/android/compositor.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	ui/android/java/src/org/chromium/ui/base/ActivityWindowAndroid.java	View		2 chunks	+0 lines, -42 lines	0 comments	Download
M	ui/android/java/src/org/chromium/ui/base/WindowAndroid.java	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	ui/base/android/window_android.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/base/android/window_android.cc	View		1 chunk	+0 lines, -16 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Ted C

lgtm https://codereview.chromium.org/297683005/diff/40001/content/browser/android/content_readback_handler.cc File content/browser/android/content_readback_handler.cc (right): https://codereview.chromium.org/297683005/diff/40001/content/browser/android/content_readback_handler.cc#newcode37 content/browser/android/content_readback_handler.cc:37: void ContentReadbackHandler::OnFinishReadback(int readback_id, Just noticed, but the function ...

6 years, 7 months ago (2014-05-21 17:56:29 UTC) #3

powei

https://codereview.chromium.org/297683005/diff/40001/content/browser/android/content_readback_handler.cc File content/browser/android/content_readback_handler.cc (right): https://codereview.chromium.org/297683005/diff/40001/content/browser/android/content_readback_handler.cc#newcode37 content/browser/android/content_readback_handler.cc:37: void ContentReadbackHandler::OnFinishReadback(int readback_id, On 2014/05/21 17:56:29, Ted C wrote: ...

6 years, 7 months ago (2014-05-23 01:15:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/powei@chromium.org/297683005/70001

6 years, 7 months ago (2014-05-27 17:28:24 UTC) #6

Message was sent while issue was closed.

Change committed as 273026

Expand Messages | Collapse Messages