content/browser/renderer_host/compositor_impl_android.cc - Issue 297683005: android: add Java-side support for browser compositor async readback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/compositor_impl_android.cc

Issue 297683005: android: add Java-side support for browser compositor async readback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed tedchoc comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/compositor_impl_android.h ('k') | content/public/android/java/src/org/chromium/content/browser/ContentReadbackHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/compositor_impl_android.cc

diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc

index 2deb35849e7b4ead535b74c524c13ef34e961407..5e01b739eb97a37aa97d1c413c621fb9dcff60c3 100644

--- a/content/browser/renderer_host/compositor_impl_android.cc

+++ b/content/browser/renderer_host/compositor_impl_android.cc

@@ -438,10 +438,6 @@ void CompositorImpl::SetHasTransparentBackground(bool flag) {

host_->set_has_transparent_background(flag);

}

-bool CompositorImpl::CompositeAndReadback(void *pixels, const gfx::Rect& rect) {

- return false;

void CompositorImpl::SetNeedsComposite() {

if (!host_.get() || needs_composite_)

return;