Remove conflicting modules flag.

Remove conflicting modules flag.

BUG=350921
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273053

[Finnur, 2014-05-20 15:48:45]

You reviewed my last change related to this (when turning it on for XP, issue
15969017). Mind reviewing the flag removal?

[cpu_(ooo_6.6-7.5), 2014-05-20 17:23:53]

So we are enabling this for all people? it seems it was under an experiment
before?

More context pleeeese.

[Finnur, 2014-05-20 17:36:19]

No, it is the opposite. We are restricting it. Before it was XP *or* the people
who had the flag set. Now it is only XP.

It was meant to be behind a flag until we gained confidence in the experiment,
but there were concerns with turning it on for everyone -- so that never got
traction. This really just confirms what has been known for quite a while; that
we're not going to enable it for all.

[cpu_(ooo_6.6-7.5), 2014-05-20 18:38:55]

I understand now. lets put that info in the bug.

Brian gone, I guess the feature will be zombie now. Let me ask upstairs to see
if we can remove it wholesale.

[Finnur, 2014-05-21 11:19:03]

Couple of points here...

1) Brian was never a stakeholder in this feature, so I don't see how his
departure changes much. It certainly does not imply the feature is now zombie.

2) The feature was intended as a tool for ConOps and users to figure out what
problematic DLLs exist in their browsers. It was never dependent on being run
automatically at startup, that's just something I pitched to make it more
prominent.

3) Once it was implemented, new stakeholders popped up: It got integrated into
your diagnostics tool and laforge wanted to run it automatically on XP because
we were seeing crashes go through the roof with certain DLLs that we could
easily warn the user about. If we are planning to kill your diagnostics mode
then that's one less stakeholder, but I don't think the XP problem has gone
away. And that still leaves at least ConOps as a stakeholder.

[cpu_(ooo_6.6-7.5), 2014-05-23 01:19:16]

lgtm

[Finnur, 2014-05-23 11:04:54]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2014-05-23 11:05:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/finnur@chromium.org/297683004/20001

[commit-bot: I haz the power, 2014-05-23 16:35:08]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 17:52:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 17:52:28]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[Finnur, 2014-05-27 16:52:52]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2014-05-27 16:53:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/finnur@chromium.org/297683004/40001

[commit-bot: I haz the power, 2014-05-27 20:29:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-27 22:22:07]

Change committed as 273053