Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4019)

Unified Diff: chrome/browser/enumerate_modules_model_win.cc

Issue 297683004: Remove conflicting modules flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/enumerate_modules_model_win.cc
diff --git a/chrome/browser/enumerate_modules_model_win.cc b/chrome/browser/enumerate_modules_model_win.cc
index 78c01a43e9aa6982b46eea9dfa34d92819082c78..dc7fbbff45bb698e419e538b27e2b3f807de127d 100644
--- a/chrome/browser/enumerate_modules_model_win.cc
+++ b/chrome/browser/enumerate_modules_model_win.cc
@@ -987,8 +987,7 @@ void EnumerateModulesModel::MaybePostScanningTask() {
done = true;
const CommandLine& cmd_line = *CommandLine::ForCurrentProcess();
- if (cmd_line.HasSwitch(switches::kConflictingModulesCheck) ||
- base::win::GetVersion() == base::win::VERSION_XP) {
+ if (base::win::GetVersion() == base::win::VERSION_XP) {
check_modules_timer_.Start(FROM_HERE,
base::TimeDelta::FromMilliseconds(kModuleCheckDelayMs),
this, &EnumerateModulesModel::ScanNow);
@@ -1030,18 +1029,6 @@ void EnumerateModulesModel::DoneScanning() {
chrome::NOTIFICATION_MODULE_LIST_ENUMERATED,
content::Source<EnumerateModulesModel>(this),
content::NotificationService::NoDetails());
-
- // Command line flag must be enabled for the notification to get sent out.
- // Otherwise we'd get the badge (while the feature is disabled) when we
- // navigate to about:conflicts and find confirmed matches.
- const CommandLine& cmd_line = *CommandLine::ForCurrentProcess();
- if (!cmd_line.HasSwitch(switches::kConflictingModulesCheck))
- return;
-
- content::NotificationService::current()->Notify(
- chrome::NOTIFICATION_MODULE_INCOMPATIBILITY_BADGE_CHANGE,
- content::Source<EnumerateModulesModel>(this),
- content::NotificationService::NoDetails());
}
GURL EnumerateModulesModel::ConstructHelpCenterUrl(
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698