Remove all calls to domAutomationController.setAutomationId.

Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG=662543
This CL was uploaded by git cl split.

R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2976803002
Cr-Commit-Position: refs/heads/master@{#485961}
Committed: https://chromium.googlesource.com/chromium/src/+/dbe11ccccad66e2228b1622adda81dc651042788

[Łukasz Anforowicz, 2017-07-11 21:45:01]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 21:45:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-07-11 23:45:47]

avi@, PTAL?

[commit-bot: I haz the power, 2017-07-12 00:04:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 00:04:12]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2017-07-12 02:51:54]

LGTM

What is this git cl split magic?!

[Łukasz Anforowicz, 2017-07-12 15:28:45]

On 2017/07/12 02:51:54, Avi (ping after 24h) wrote:
> LGTM

Thanks!
> 
> What is this git cl split magic?!

The gist is that you start with a big CL, but one that doesn't have any internal
interdependencies (I've started with
https://codereview.chromium.org/2974303002).  You then run "git cl split" and it
will 1) split the CL into local git branches, where each branch has at most 1
owner, 2) it will run "git cl upload" from each branch and kick off tryjobs.

OTOH, I am not sure if I'll be using "git cl split" again soon:

1. Splitting my CL into 24 (!) CLs seems a bit excessive.
   ("git rebase-update" will probably complain about too many local branches
    next time I run it)
2. The owner lookup is not ideal
   - The tool cannot read comments and doesn't know that some owners
     should only be picked for specific things
   - I had to manually tweak the tool so that it doesn't choke
     on files with only ["*"] owners.
3. I had to comment out passing of --send-email to "git cl upload"
   (it didn't work).

[Łukasz Anforowicz, 2017-07-12 15:28:51]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-07-12 15:28:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2017-07-12 15:31:47]

On 2017/07/12 15:28:45, Łukasz A. wrote:
> On 2017/07/12 02:51:54, Avi (ping after 24h) wrote:
> > LGTM
> 
> Thanks!
> > 
> > What is this git cl split magic?!
> 
> The gist is that you start with a big CL, but one that doesn't have any
internal
> interdependencies (I've started with
> https://codereview.chromium.org/2974303002).  You then run "git cl split" and
it
> will 1) split the CL into local git branches, where each branch has at most 1
> owner, 2) it will run "git cl upload" from each branch and kick off tryjobs.
> 
> OTOH, I am not sure if I'll be using "git cl split" again soon:
> 
> 1. Splitting my CL into 24 (!) CLs seems a bit excessive.
>    ("git rebase-update" will probably complain about too many local branches
>     next time I run it)
> 2. The owner lookup is not ideal
>    - The tool cannot read comments and doesn't know that some owners
>      should only be picked for specific things
>    - I had to manually tweak the tool so that it doesn't choke
>      on files with only ["*"] owners.
> 3. I had to comment out passing of --send-email to "git cl upload"
>    (it didn't work).

Thank you for sharing your experience. I've done some splitting of CLs in the
past, and that does sound limiting. I'll probably keep doing it manually.

[commit-bot: I haz the power, 2017-07-12 15:32:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499873331626910, "parent_rev":
"be24cfe8bb8e232d1c48631f1175009e66204b40", "commit_rev":
"dbe11ccccad66e2228b1622adda81dc651042788"}

[commit-bot: I haz the power, 2017-07-12 15:32:50]

Description was changed from

==========
Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG=662543
This CL was uploaded by git cl split.

R=avi@chromium.org
==========

to

==========
Remove all calls to domAutomationController.setAutomationId.

These calls are no longer needed after r485461
(https://crrev.com/2478803003) which has made the
domAutomationController.setAutomationId call a no-op.

BUG=662543
This CL was uploaded by git cl split.

R=avi@chromium.org

Review-Url: https://codereview.chromium.org/2976803002
Cr-Commit-Position: refs/heads/master@{#485961}
Committed:
https://chromium.googlesource.com/chromium/src/+/dbe11ccccad66e2228b1622adda8...
==========

[commit-bot: I haz the power, 2017-07-12 15:32:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dbe11ccccad66e2228b1622adda8...