Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2976793002: Remove all calls to domAutomationController.setAutomationId. (Closed)

Created:
3 years, 5 months ago by Łukasz Anforowicz
Modified:
3 years, 4 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, extensions-reviews_chromium.org, vabr+watchlistpasswordmanager_chromium.org, dcheng, chromium-apps-reviews_chromium.org, piman+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove all calls to domAutomationController.setAutomationId. These calls are no longer needed after r485461 (https://crrev.com/2478803003) which has made the domAutomationController.setAutomationId call a no-op. BUG=662543 This CL was uploaded by git cl split. R=nick Review-Url: https://codereview.chromium.org/2976793002 Cr-Commit-Position: refs/heads/master@{#496129} Committed: https://chromium.googlesource.com/chromium/src/+/c91fdd56c49d8c96889c4dafe0ed1f585a0632b2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -23 lines) Patch
M chrome/test/data/ads_observer/docwrite_provisional_frame.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/automation/sends_message_on_load.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/chrome_extension_resource.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/drag_and_drop/event_monitoring.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/test_file_with_ctrl-d_keybinding.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/canvas_popup.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/feature_canvas2d.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/feature_multisampling.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/feature_raf_no_damage.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/feature_webgl.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/gpu/webgl_conformance.html View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/gpu/webgl_popup.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/keyevents_test.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/local_ntp_browsertest.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/page_with_focus_events.html View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/password/frame_detached_on_submit.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/password/password_fetch_submit.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/password/password_xhr_submit.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/popup_iframe.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/supervised_user/with_iframes.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/tab-restore-visibility.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (15 generated)
Łukasz Anforowicz
nick@, can you PTAL?
3 years, 5 months ago (2017-07-11 23:55:49 UTC) #3
ncarter (slow)
lgtm
3 years, 4 months ago (2017-07-31 20:04:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976793002/1
3 years, 4 months ago (2017-07-31 20:04:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/513798)
3 years, 4 months ago (2017-07-31 21:30:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976793002/1
3 years, 4 months ago (2017-08-21 23:48:11 UTC) #18
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 23:55:17 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c91fdd56c49d8c96889c4dafe0ed...

Powered by Google App Engine
This is Rietveld 408576698