Issue 297663003: Stop using urllib.urlretrieve() directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 297663003: Stop using urllib.urlretrieve() directly. (Closed)

Created:
6 years, 7 months ago by Raphael Kubo da Costa (rakuco)

Modified:
6 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Stop using urllib.urlretrieve() directly. Using urllib for SSL connections when behind a proxy is known to be broken, so apply the same fix from depot_tools r149742 and use a wrapper around urllib2 instead. R=jkummerow@chromium.org TEST=run test262 behind corporate proxy Committed: https://code.google.com/p/v8/source/detail?r=21402

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -5 lines)			Patch
M	test/promises-aplus/testcfg.py	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	test/test262/testcfg.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testrunner/local/utils.py	View	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

6 years, 7 months ago (2014-05-21 09:25:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21402 (presubmit successful).

Expand Messages | Collapse Messages