Stop using urllib.urlretrieve() directly.

test/promises-aplus/testcfg.py

 # Copyright 2014 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 13 matching lines @@
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 
 import hashlib
 import os
 import shutil
 import sys
 import tarfile
-import urllib
 
 from testrunner.local import testsuite
+from testrunner.local import utils
 from testrunner.objects import testcase
 
 
 SINON_TAG = '1.7.3'
 SINON_NAME = 'sinon'
 SINON_FILENAME = 'sinon.js'
 SINON_URL = 'http://sinonjs.org/releases/sinon-' + SINON_TAG + '.js'
 SINON_HASH = 'b7ab4dd9a1a2cf0460784af3728ad15caf4bbea923f680c5abde5c8332f35984'
 
 TEST_TAG = '2.0.3'
@@ skipping 48 matching lines @@
     if output.exit_code != 0:
       return True
     return not 'All tests have run.' in output.stdout or \
            'FAIL:' in output.stdout
 
   def DownloadTestData(self):
     archive = os.path.join(self.root, TEST_ARCHIVE)
     directory = os.path.join(self.root, TEST_NAME)
     if not os.path.exists(archive):
       print('Downloading {0} from {1} ...'.format(TEST_NAME, TEST_URL))
-      urllib.urlretrieve(TEST_URL, archive)
+      utils.URLRetrieve(TEST_URL, archive)
       if os.path.exists(directory):
         shutil.rmtree(directory)
 
     if not os.path.exists(directory):
       print('Extracting {0} ...'.format(TEST_ARCHIVE))
       hash = hashlib.sha256()
       with open(archive, 'rb') as f:
         for chunk in iter(lambda: f.read(8192), ''):
           hash.update(chunk)
         if hash.hexdigest() != TEST_ARCHIVE_HASH:
           os.remove(archive)
           raise Exception('Hash mismatch of test data file')
       archive = tarfile.open(archive, 'r:gz')
       if sys.platform in ('win32', 'cygwin'):
         # Magic incantation to allow longer path names on Windows.
         archive.extractall(u'\\\\?\\%s' % self.root)
       else:
         archive.extractall(self.root)
       shutil.move(os.path.join(self.root, TEST_ARCHIVE_TOP), directory)
 
   def DownloadSinon(self):
     directory = os.path.join(self.root, SINON_NAME)
     if not os.path.exists(directory):
       os.mkdir(directory)
     path = os.path.join(directory, SINON_FILENAME)
     if not os.path.exists(path):
-      urllib.urlretrieve(SINON_URL, path)
+      utils.URLRetrieve(SINON_URL, path)
     hash = hashlib.sha256()
     with open(path, 'rb') as f:
       for chunk in iter(lambda: f.read(8192), ''):
         hash.update(chunk)
     if hash.hexdigest() != SINON_HASH:
       os.remove(path)
       raise Exception('Hash mismatch of test data file')
 
   def DownloadData(self):
     self.DownloadTestData()
     self.DownloadSinon()
 
 
 def GetSuite(name, root):
   return PromiseAplusTestSuite(name, root)