Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2976583002: [grpc/logging] Update to LoggerV2. (Closed)

Created:
3 years, 5 months ago by dnj
Modified:
3 years, 5 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[grpc/logging] Update to LoggerV2. The gRPC package has released its "LoggerV2" interface, which tries to maintain backwards compatibility with Logger but fails (see https://github.com/grpc/grpc-go/issues/1360). Update our gRPC logging adapter to operate through LoggerV2. BUG=None TEST=unit Review-Url: https://codereview.chromium.org/2976583002 Committed: https://github.com/luci/luci-go/commit/20552da21fbd9b430045c43a86735ff3c8f3cea8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -110 lines) Patch
M grpc/logging/grpc_logger.go View 3 chunks +106 lines, -42 lines 0 comments Download
M grpc/logging/grpc_logger_test.go View 3 chunks +92 lines, -67 lines 0 comments Download
M logdog/client/cmd/logdog_butler/main.go View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
dnj
PTAL. This is blocking LUCI CQ at the moment, b/c of referenced issue.
3 years, 5 months ago (2017-07-08 18:42:45 UTC) #4
iannucci
lgtm
3 years, 5 months ago (2017-07-10 18:14:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976583002/1
3 years, 5 months ago (2017-07-10 18:16:18 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 18:23:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/20552da21fbd9b430045c43a86735ff3c8f3cea8

Powered by Google App Engine
This is Rietveld 408576698