Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 2976533002: Update macOS FYI toolchain bot to compile with 10.12 SDK. (Closed)

Created:
3 years, 5 months ago by erikchen
Modified:
3 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update macOS FYI toolchain bot to compile with 10.12 SDK. BUG=669240 Review-Url: https://codereview.chromium.org/2976533002 Cr-Commit-Position: refs/heads/master@{#485094} Committed: https://chromium.googlesource.com/chromium/src/+/92403640ba1c95cccb6c852a41ff5ffde467900f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
erikchen
dpranke: Please review.
3 years, 5 months ago (2017-07-07 21:58:45 UTC) #3
Dirk Pranke
lgtm
3 years, 5 months ago (2017-07-07 22:08:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976533002/1
3 years, 5 months ago (2017-07-07 22:11:18 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 23:22:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/92403640ba1c95cccb6c852a41ff...

Powered by Google App Engine
This is Rietveld 408576698