Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2976523002: Fix ftp subresource deprecation message. (Closed)

Created:
3 years, 5 months ago by mmenke
Modified:
3 years, 5 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ftp subresource deprecation message. It has two "are"s in a row. BUG=none Review-Url: https://codereview.chromium.org/2976523002 Cr-Commit-Position: refs/heads/master@{#485307} Committed: https://chromium.googlesource.com/chromium/src/+/37ef79a0f6f96a7f555179492958c0048bade121

Patch Set 1 #

Patch Set 2 : Fix LayoutTests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/multiple-report-policies-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/security/deprecated-subresource-requests-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/security/block-test-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (11 generated)
mmenke
Despite 7 years working on Chrome, I think this is the first time I've sent ...
3 years, 5 months ago (2017-07-07 20:10:28 UTC) #2
Mike West
Excellent! You'll likely need to update some test expectations that contain this string as well; ...
3 years, 5 months ago (2017-07-10 09:53:07 UTC) #5
Mike West
Looks like it'll be these three: - third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/multiple-report-policies-expected.txt - third_party/WebKit/LayoutTests/http/tests/security/deprecated-subresource-requests-expected.txt - third_party/WebKit/LayoutTests/security/block-test-expected.txt LGTM if you ...
3 years, 5 months ago (2017-07-10 09:54:12 UTC) #6
mmenke
On 2017/07/10 09:54:12, Mike West wrote: > Looks like it'll be these three: > > ...
3 years, 5 months ago (2017-07-10 15:11:17 UTC) #9
mmenke
On 2017/07/10 15:11:17, mmenke wrote: > On 2017/07/10 09:54:12, Mike West wrote: > > Looks ...
3 years, 5 months ago (2017-07-10 15:11:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976523002/20001
3 years, 5 months ago (2017-07-10 15:11:50 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/495585)
3 years, 5 months ago (2017-07-10 16:48:02 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976523002/20001
3 years, 5 months ago (2017-07-10 16:51:05 UTC) #17
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 17:31:27 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/37ef79a0f6f96a7f555179492958...

Powered by Google App Engine
This is Rietveld 408576698