Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2976453002: Disable UKM on Android (Closed)

Created:
3 years, 5 months ago by Steven Holte
Modified:
3 years, 5 months ago
Reviewers:
rkaplow, rkaplow1
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable UKM on Android BUG=739971, 734091 Review-Url: https://codereview.chromium.org/2976453002 Cr-Commit-Position: refs/heads/master@{#485088} Committed: https://chromium.googlesource.com/chromium/src/+/094e496b0751a1efa5463cba8662318499d1fec8

Patch Set 1 #

Patch Set 2 : Disable UKM on Android #

Total comments: 2

Patch Set 3 : Actually disable #

Patch Set 4 : Fix name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/browser/metrics/chrome_metrics_services_manager_client.cc View 1 2 3 2 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Steven Holte
Disabling here in code for now, until we have a proper fix.
3 years, 5 months ago (2017-07-07 01:28:27 UTC) #2
rkaplow
https://codereview.chromium.org/2976453002/diff/20001/chrome/browser/metrics/chrome_metrics_services_manager_client.cc File chrome/browser/metrics/chrome_metrics_services_manager_client.cc (right): https://codereview.chromium.org/2976453002/diff/20001/chrome/browser/metrics/chrome_metrics_services_manager_client.cc#newcode298 chrome/browser/metrics/chrome_metrics_services_manager_client.cc:298: return false; shouldn't this be true?
3 years, 5 months ago (2017-07-07 13:53:42 UTC) #3
Steven Holte
https://codereview.chromium.org/2976453002/diff/20001/chrome/browser/metrics/chrome_metrics_services_manager_client.cc File chrome/browser/metrics/chrome_metrics_services_manager_client.cc (right): https://codereview.chromium.org/2976453002/diff/20001/chrome/browser/metrics/chrome_metrics_services_manager_client.cc#newcode298 chrome/browser/metrics/chrome_metrics_services_manager_client.cc:298: return false; On 2017/07/07 13:53:41, rkaplow wrote: > shouldn't ...
3 years, 5 months ago (2017-07-07 19:08:41 UTC) #4
rkaplow1
lgtm
3 years, 5 months ago (2017-07-07 19:18:21 UTC) #6
rkaplow
lgtm
3 years, 5 months ago (2017-07-07 19:27:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976453002/40001
3 years, 5 months ago (2017-07-07 20:44:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/496018)
3 years, 5 months ago (2017-07-07 21:02:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2976453002/60001
3 years, 5 months ago (2017-07-07 22:00:53 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 23:14:09 UTC) #17
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/094e496b0751a1efa5463cba8662...

Powered by Google App Engine
This is Rietveld 408576698