Chromium Code Reviews| Index: content/network/network_context.h |
| diff --git a/content/network/network_context.h b/content/network/network_context.h |
| index c50fc033244f53f9a63cf1d3788e4aaae171bad6..7bcb1b63292ab905d22b779ee6b8fe0010480666 100644 |
| --- a/content/network/network_context.h |
| +++ b/content/network/network_context.h |
| @@ -26,6 +26,19 @@ namespace content { |
| class NetworkServiceImpl; |
| class URLLoaderImpl; |
| +// A NetworkContext creates and manages access to a URLRequestContext. |
| +// |
| +// When the network service is enabled, NetworkContexts are created through |
| +// NetworkService's mojo interface and are owned jointly by the NetworkService |
| +// and the NetworkContextPtr used to talk to them, and the NetworkContext is |
| +// destroyed when either one is torn down. |
| +// |
| +// When the network service is disabled, NetworkContexts may be created through |
| +// NetworkServiceImpl::CreateNetworkContextWithBuilder, and take in a |
| +// URLRequestContextBuilder to seed construction of the NetworkContext's |
| +// URLRequestContext. When that happens, the consumer takes owners the |
|
Randy Smith (Not in Mondays)
2017/07/20 17:38:34
nit: owners -> ownership of
mmenke
2017/07/20 18:31:31
Done.
|
| +// NetworkContext directly, has direct access to its URLRequestContext, and is |
| +// responsible for destroying it before the NetworkService. |
|
Randy Smith (Not in Mondays)
2017/07/20 17:38:34
Thank you for this--when I first hit this file (ea
mmenke
2017/07/20 18:31:31
No problem, though credit goes to John for suggest
|
| class NetworkContext : public mojom::NetworkContext { |
| public: |
| NetworkContext(NetworkServiceImpl* network_service, |