Hook up ProfileIOData's URLRequestContext to a NetworkService.

content/network/network_context.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_NETWORK_NETWORK_CONTEXT_H_
 #define CONTENT_NETWORK_NETWORK_CONTEXT_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <set>
 
 #include "base/macros.h"
 #include "content/common/content_export.h"
 #include "content/public/common/network_service.mojom.h"
 #include "content/public/common/url_loader_factory.mojom.h"
 #include "mojo/public/cpp/bindings/binding.h"
 #include "mojo/public/cpp/bindings/strong_binding_set.h"
 
 namespace net {
 class URLRequestContext;
 class URLRequestContextBuilder;
 }
 
 namespace content {
 class NetworkServiceImpl;
 class URLLoaderImpl;
 
+// A NetworkContext creates and manages access to a URLRequestContext.
+//
+// When the network service is enabled, NetworkContexts are created through
+// NetworkService's mojo interface and are owned jointly by the NetworkService
+// and the NetworkContextPtr used to talk to them, and the NetworkContext is
+// destroyed when either one is torn down.
+//
+// When the network service is disabled, NetworkContexts may be created through
+// NetworkServiceImpl::CreateNetworkContextWithBuilder, and take in a
+// URLRequestContextBuilder to seed construction of the NetworkContext's
+// URLRequestContext. When that happens, the consumer takes owners the

[Randy Smith (Not in Mondays), 2017/07/20 17:38:34]

nit: owners -> ownership of

[mmenke, 2017/07/20 18:31:31]

Done.

+// NetworkContext directly, has direct access to its URLRequestContext, and is
+// responsible for destroying it before the NetworkService.

[Randy Smith (Not in Mondays), 2017/07/20 17:38:34]

Thank you for this--when I first hit this file (earlier in the CL) there was
some frustration over the lack of these paragraphs.

[mmenke, 2017/07/20 18:31:31]

No problem, though credit goes to John for suggesting adding comments here.

 class NetworkContext : public mojom::NetworkContext {
  public:
   NetworkContext(NetworkServiceImpl* network_service,
                  mojom::NetworkContextRequest request,
                  mojom::NetworkContextParamsPtr params);
 
   // Temporary constructor that allows creating an in-process NetworkContext
   // with a pre-populated URLRequestContextBuilder.
   NetworkContext(mojom::NetworkContextRequest request,
                  mojom::NetworkContextParamsPtr params,
@@ skipping 45 matching lines @@
   mojom::NetworkContextParamsPtr params_;
 
   mojo::Binding<mojom::NetworkContext> binding_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkContext);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_NETWORK_NETWORK_CONTEXT_H_