Embeds offline voice recognizer plugin and its manager to app-list start page.

Embeds offline voice recognizer plugin and its manager to app-list start page.

BUG=312365
R=xiyuan@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232311

[xiyuan, 2013-10-29 18:10:07]

LGTM

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
File chrome/browser/resources/app_list/audio_manager.js (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
chrome/browser/resources/app_list/audio_manager.js:57:
AudioManager.prototype.onAudioProcess_ = function(audio_event) {
audio_event -> audioEvent

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
File chrome/browser/resources/app_list/speech_recognition_manager.js (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
chrome/browser/resources/app_list/speech_recognition_manager.js:58:
this.delegate_.onSpeechRecognitionError.bind(this.delegate_);
nit: move these into constructor so that we have one place for hooking up
this.recognizer_ events.

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/app_lis...
File chrome/browser/ui/app_list/start_page_service.h (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/app_lis...
chrome/browser/ui/app_list/start_page_service.h:47: class
StartPageWebContentsDelegate;
nit: Doc the class.

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/webui/a...
File chrome/browser/ui/webui/app_list/start_page_ui.cc (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/webui/a...
chrome/browser/ui/webui/app_list/start_page_ui.cc:44: base::RefCountedString*
data = new base::RefCountedString();
nit: use scoped_refptr<base::RefCountedString>

[Jun Mukai, 2013-10-30 01:01:32]

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
File chrome/browser/resources/app_list/audio_manager.js (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
chrome/browser/resources/app_list/audio_manager.js:57:
AudioManager.prototype.onAudioProcess_ = function(audio_event) {
On 2013/10/29 18:10:07, xiyuan wrote:
> audio_event -> audioEvent

Done.

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
File chrome/browser/resources/app_list/speech_recognition_manager.js (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/...
chrome/browser/resources/app_list/speech_recognition_manager.js:58:
this.delegate_.onSpeechRecognitionError.bind(this.delegate_);
On 2013/10/29 18:10:07, xiyuan wrote:
> nit: move these into constructor so that we have one place for hooking up
> this.recognizer_ events.

Done.

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/app_lis...
File chrome/browser/ui/app_list/start_page_service.h (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/app_lis...
chrome/browser/ui/app_list/start_page_service.h:47: class
StartPageWebContentsDelegate;
On 2013/10/29 18:10:07, xiyuan wrote:
> nit: Doc the class.

Done.

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/webui/a...
File chrome/browser/ui/webui/app_list/start_page_ui.cc (right):

https://codereview.chromium.org/29763004/diff/50001/chrome/browser/ui/webui/a...
chrome/browser/ui/webui/app_list/start_page_ui.cc:44: base::RefCountedString*
data = new base::RefCountedString();
On 2013/10/29 18:10:07, xiyuan wrote:
> nit: use scoped_refptr<base::RefCountedString>

Done.

[commit-bot: I haz the power, 2013-10-31 03:02:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/140012

[commit-bot: I haz the power, 2013-10-31 03:22:53]

Retried try job too often on android_aosp for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_ao...

[commit-bot: I haz the power, 2013-10-31 17:45:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/140012

[commit-bot: I haz the power, 2013-10-31 20:56:41]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-10-31 23:12:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/590001

[commit-bot: I haz the power, 2013-11-01 03:31:19]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-01 03:55:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/590001

[commit-bot: I haz the power, 2013-11-01 07:01:34]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-11-01 07:19:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/590001

[commit-bot: I haz the power, 2013-11-01 09:04:26]

Change committed as 232311