Chromium Code Reviews
Help | Chromium Project | Sign in
(118)

Issue 29763004: Embeds offline voice recognizer plugin and its manager to app-list start page. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by Jun Mukai
Modified:
5 months, 3 weeks ago
Reviewers:
xiyuan
Visibility:
Public.

Description

Embeds offline voice recognizer plugin and its manager to app-list start page.

BUG=312365
R=xiyuan@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232311

Patch Set 1 #

Patch Set 2 : cleanup JS #

Patch Set 3 : remove debug div but use console.log #

Total comments: 8

Patch Set 4 : fix #

Patch Set 5 : rebase #

Patch Set 6 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+625 lines, -1 line) Lint Patch
A chrome/browser/resources/app_list/audio_manager.js View 1 2 3 4 5 1 chunk +123 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/app_list/greconacl.nmf View 1 1 chunk +7 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/app_list/plugin_manager.js View 1 2 3 4 5 1 chunk +160 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/app_list/speech_manager.js View 1 2 1 chunk +152 lines, -0 lines 0 comments ? errors Download
A chrome/browser/resources/app_list/speech_recognition_manager.js View 1 2 3 1 chunk +73 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/app_list/start_page.html View 1 2 1 chunk +4 lines, -0 lines 0 comments ? errors Download
M chrome/browser/resources/app_list/start_page.js View 1 3 chunks +15 lines, -1 line 0 comments ? errors Download
M chrome/browser/ui/app_list/start_page_service.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments ? errors Download
M chrome/browser/ui/app_list/start_page_service.cc View 1 4 chunks +22 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/ui/webui/app_list/start_page_ui.cc View 1 2 3 2 chunks +57 lines, -0 lines 0 comments ? errors Download
M ui/app_list/views/apps_grid_view.cc View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 13
Jun Mukai
5 months, 3 weeks ago #1
xiyuan
LGTM https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/app_list/audio_manager.js File chrome/browser/resources/app_list/audio_manager.js (right): https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/app_list/audio_manager.js#newcode57 chrome/browser/resources/app_list/audio_manager.js:57: AudioManager.prototype.onAudioProcess_ = function(audio_event) { audio_event -> audioEvent https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/app_list/speech_recognition_manager.js ...
5 months, 3 weeks ago #2
Jun Mukai
https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/app_list/audio_manager.js File chrome/browser/resources/app_list/audio_manager.js (right): https://codereview.chromium.org/29763004/diff/50001/chrome/browser/resources/app_list/audio_manager.js#newcode57 chrome/browser/resources/app_list/audio_manager.js:57: AudioManager.prototype.onAudioProcess_ = function(audio_event) { On 2013/10/29 18:10:07, xiyuan wrote: ...
5 months, 3 weeks ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/140012
5 months, 3 weeks ago #4
I haz the power (commit-bot)
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=23687
5 months, 3 weeks ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/140012
5 months, 3 weeks ago #6
I haz the power (commit-bot)
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=183276
5 months, 3 weeks ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/590001
5 months, 3 weeks ago #8
I haz the power (commit-bot)
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217101
5 months, 3 weeks ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/590001
5 months, 3 weeks ago #10
I haz the power (commit-bot)
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=217229
5 months, 3 weeks ago #11
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/29763004/590001
5 months, 3 weeks ago #12
I haz the power (commit-bot)
5 months, 3 weeks ago #13
Message was sent while issue was closed.
Change committed as 232311
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6