Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2976173002: Move NullError into interceptors (Closed)

Created:
3 years, 5 months ago by Leaf
Modified:
3 years, 5 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move NullError into interceptors Put the NullError class into interceptors so that it will be picked up as a native type. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/4a87156b131d68ece46826577e31c036dfa0a27c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/interceptors.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_helper.dart View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
3 years, 5 months ago (2017-07-13 21:30:40 UTC) #2
vsm
lgtm - thanks!
3 years, 5 months ago (2017-07-13 21:31:32 UTC) #3
Leaf
3 years, 5 months ago (2017-07-13 21:38:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a87156b131d68ece46826577e31c036dfa0a27c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698