Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: pkg/dev_compiler/tool/input_sdk/private/interceptors.dart

Issue 2976173002: Move NullError into interceptors (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart._interceptors; 5 library dart._interceptors;
6 6
7 import 'dart:collection'; 7 import 'dart:collection';
8 import 'dart:_internal' hide Symbol; 8 import 'dart:_internal' hide Symbol;
9 import 'dart:_js_helper'; 9 import 'dart:_js_helper';
10 import 'dart:_foreign_helper' show JS; 10 import 'dart:_foreign_helper' show JS;
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
87 * non-trivial prototype chain. 87 * non-trivial prototype chain.
88 * 88 *
89 * This class also serves as a fallback for unknown JavaScript exceptions. 89 * This class also serves as a fallback for unknown JavaScript exceptions.
90 */ 90 */
91 class UnknownJavaScriptObject extends JavaScriptObject { 91 class UnknownJavaScriptObject extends JavaScriptObject {
92 const UnknownJavaScriptObject(); 92 const UnknownJavaScriptObject();
93 93
94 String toString() => JS('String', 'String(#)', this); 94 String toString() => JS('String', 'String(#)', this);
95 } 95 }
96 96
97 // Note that this needs to be in interceptors.dart in order for
98 // it to be picked up as an extension type.
99 @JsPeerInterface(name: 'TypeError')
100 class NullError extends Interceptor implements NoSuchMethodError {
101 StackTrace get stackTrace => Primitives.extractStackTrace(this);
102
103 String toString() {
104 // TODO(vsm): Distinguish between null reference errors and other
105 // TypeErrors. We should not get non-null TypeErrors from DDC code,
106 // but we may from native JavaScript.
107 var message = JS('String', '#.message', this);
108 return "NullError: $message";
109 }
110 }
111
97 // Obsolete in dart dev compiler. Added only so that the same version of 112 // Obsolete in dart dev compiler. Added only so that the same version of
98 // dart:html can be used in dart2js an dev compiler. 113 // dart:html can be used in dart2js an dev compiler.
99 // Warning: calls to these methods need to be removed before custom elements 114 // Warning: calls to these methods need to be removed before custom elements
100 // and cross-frame dom objects behave correctly in ddc. 115 // and cross-frame dom objects behave correctly in ddc.
101 // See https://github.com/dart-lang/sdk/issues/28326 116 // See https://github.com/dart-lang/sdk/issues/28326
102 findInterceptorConstructorForType(Type type) {} 117 findInterceptorConstructorForType(Type type) {}
103 findConstructorForNativeSubclassType(Type type, String name) {} 118 findConstructorForNativeSubclassType(Type type, String name) {}
104 getNativeInterceptor(object) {} 119 getNativeInterceptor(object) {}
105 setDispatchProperty(object, value) {} 120 setDispatchProperty(object, value) {}
OLDNEW
« no previous file with comments | « pkg/dev_compiler/lib/sdk/ddc_sdk.sum ('k') | pkg/dev_compiler/tool/input_sdk/private/js_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698