Delay logging about missing certifi until it is really needed.

Delay logging about missing certifi until it is really needed.

Logging during module import time is not cool, it causes logger to auto
configure itself with some (wrong) defaults.

It eventually triggers assert in logging_utilities.prepare_logging (that gets
confused because the logger is already configured).

R=maruel@chromium.org, iannucci@chromium.org, aludwin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2976073002
Committed: https://github.com/luci/luci-py/commit/b0cc1ee633f836e6e7a358b5fc5ce7fdd758040b

[Vadim Sh., 2017-07-13 00:13:01]

This broke some portion of Swarming tasks on chromium-swarm :( E.g
https://chromium-swarm.appspot.com/task?id=375217e9db9ccb10&refresh=10&show_r...

[smut, 2017-07-13 00:14:22]

smut@google.com changed reviewers:
+ smut@google.com

[smut, 2017-07-13 00:14:23]

lgtm

[smut, 2017-07-13 00:15:36]

https://codereview.chromium.org/2976073002/diff/1/client/isolate_storage.py
File client/isolate_storage.py (right):

https://codereview.chromium.org/2976073002/diff/1/client/isolate_storage.py#n...
client/isolate_storage.py:45: except ImportError as err:
Unused variable "err".

[Vadim Sh., 2017-07-13 00:15:43]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2017-07-13 00:15:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Vadim Sh., 2017-07-13 00:16:31]

The CQ bit was unchecked by vadimsh@chromium.org

[Vadim Sh., 2017-07-13 00:18:03]

https://codereview.chromium.org/2976073002/diff/1/client/isolate_storage.py
File client/isolate_storage.py (right):

https://codereview.chromium.org/2976073002/diff/1/client/isolate_storage.py#n...
client/isolate_storage.py:45: except ImportError as err:
On 2017/07/13 00:15:36, smut wrote:
> Unused variable "err".

Done.

[Vadim Sh., 2017-07-13 00:18:16]

The CQ bit was checked by vadimsh@chromium.org

[Vadim Sh., 2017-07-13 00:18:17]

The patchset sent to the CQ was uploaded after l-g-t-m from smut@google.com
Link to the patchset: https://codereview.chromium.org/2976073002/#ps20001
(title: "nits, more comments")

[commit-bot: I haz the power, 2017-07-13 00:18:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Vadim Sh., 2017-07-13 00:26:31]

The CQ bit was unchecked by vadimsh@chromium.org

[Vadim Sh., 2017-07-13 00:26:45]

The CQ bit was checked by vadimsh@chromium.org

[commit-bot: I haz the power, 2017-07-13 00:26:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-13 00:36:10]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499905605080830,
"parent_rev": "2abab85798f2b40ccc51791a1f41b3e85d378df0", "commit_rev":
"b0cc1ee633f836e6e7a358b5fc5ce7fdd758040b"}

[commit-bot: I haz the power, 2017-07-13 00:36:13]

Description was changed from

==========
Delay logging about missing certifi until it is really needed.

Logging during module import time is not cool, it causes logger to auto
configure itself with some (wrong) defaults.

It eventually triggers assert in logging_utilities.prepare_logging (that gets
confused because the logger is already configured).

R=maruel@chromium.org, iannucci@chromium.org, aludwin@google.com
BUG=
==========

to

==========
Delay logging about missing certifi until it is really needed.

Logging during module import time is not cool, it causes logger to auto
configure itself with some (wrong) defaults.

It eventually triggers assert in logging_utilities.prepare_logging (that gets
confused because the logger is already configured).

R=maruel@chromium.org, iannucci@chromium.org, aludwin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2976073002
Committed:
https://github.com/luci/luci-py/commit/b0cc1ee633f836e6e7a358b5fc5ce7fdd758040b
==========

[commit-bot: I haz the power, 2017-07-13 00:36:15]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/b0cc1ee633f836e6e7a358b5fc5ce7fdd758040b