Add top-level exception handler on Windows to dump stack traces

Add top-level exception handler on Windows to dump stack traces

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/2e5002d67a61dcdb36c8268ca7a3c4c995f4570e

[alexmarkov, 2017-07-12 21:42:57]

alexmarkov@google.com changed reviewers:
+ zra@google.com

[alexmarkov, 2017-07-12 21:42:57]

Hi Zach,

Could you please try to build this CL on Windows?

[zra, 2017-07-12 22:14:59]

This built and appears to work!

https://codereview.chromium.org/2976063002/diff/1/runtime/bin/platform_win.cc
File runtime/bin/platform_win.cc (right):

https://codereview.chromium.org/2976063002/diff/1/runtime/bin/platform_win.cc...
runtime/bin/platform_win.cc:40: static LONG WINAPI
Could you add a comment here with a link to the documentation for this callback
and/or struct _EXCEPTION_POINTERS.

https://codereview.chromium.org/2976063002/diff/1/runtime/bin/platform_win.cc...
runtime/bin/platform_win.cc:45: abort();
It would be polite of us to call PlatformWin::RestoreConsole() here to restore
the console even on a crash =)

[alexmarkov, 2017-07-12 22:39:48]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[alexmarkov, 2017-07-12 22:39:49]

https://codereview.chromium.org/2976063002/diff/1/runtime/bin/platform_win.cc
File runtime/bin/platform_win.cc (right):

https://codereview.chromium.org/2976063002/diff/1/runtime/bin/platform_win.cc...
runtime/bin/platform_win.cc:40: static LONG WINAPI
On 2017/07/12 22:14:59, zra wrote:
> Could you add a comment here with a link to the documentation for this
callback
> and/or struct _EXCEPTION_POINTERS.

Done.

https://codereview.chromium.org/2976063002/diff/1/runtime/bin/platform_win.cc...
runtime/bin/platform_win.cc:45: abort();
On 2017/07/12 22:14:59, zra wrote:
> It would be polite of us to call PlatformWin::RestoreConsole() here to restore
> the console even on a crash =)

Done.

[zra, 2017-07-12 22:43:54]

lgtm

[alexmarkov, 2017-07-13 15:17:35]

Description was changed from

==========
Add top-level exception handler on Windows to dump stack traces
==========

to

==========
Add top-level exception handler on Windows to dump stack traces

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2e5002d67a61dcdb36c8268ca7a3c4c995f4570e
==========

[alexmarkov, 2017-07-13 15:17:36]

Committed patchset #2 (id:20001) manually as
2e5002d67a61dcdb36c8268ca7a3c4c995f4570e (presubmit successful).