Add top-level exception handler on Windows to dump stack traces

runtime/bin/platform_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(HOST_OS_WINDOWS)
 
 #include "bin/platform.h"
 
 #include <crtdbg.h>
@@ skipping 18 matching lines @@
 #define ENABLE_VIRTUAL_TERMINAL_PROCESSING 0x0004
 #endif
 
 namespace dart {
 
 // Defined in vm/os_thread_win.cc
 extern bool private_flag_windows_run_tls_destructors;
 
 namespace bin {
 
+
+static LONG WINAPI

[zra, 2017/07/12 22:14:59]

Could you add a comment here with a link to the documentation for this callback
and/or struct _EXCEPTION_POINTERS.

[alexmarkov, 2017/07/12 22:39:49]

Done.

+DartExceptionHandler(struct _EXCEPTION_POINTERS* ExceptionInfo) {
+  if (ExceptionInfo->ExceptionRecord->ExceptionCode ==
+      EXCEPTION_ACCESS_VIOLATION) {
+    Dart_DumpNativeStackTrace(ExceptionInfo->ContextRecord);
+    abort();

[zra, 2017/07/12 22:14:59]

It would be polite of us to call PlatformWin::RestoreConsole() here to restore
the console even on a crash =)

[alexmarkov, 2017/07/12 22:39:49]

Done.

+  }
+  return EXCEPTION_CONTINUE_SEARCH;
+}
+
+
 const char* Platform::executable_name_ = NULL;
 char* Platform::resolved_executable_name_ = NULL;
 int Platform::script_index_ = 1;
 char** Platform::argv_ = NULL;
 
 class PlatformWin {
  public:
   static void InitOnce() {
     platform_win_mutex_ = new Mutex();
     saved_output_cp_ = -1;
     saved_input_cp_ = -1;
     // Set up a no-op handler so that CRT functions return an error instead of
     // hitting an assertion failure.
     // See: https://msdn.microsoft.com/en-us/library/a9yf33zb.aspx
     _set_invalid_parameter_handler(InvalidParameterHandler);
     // Disable the message box for assertions in the CRT in Debug builds.
     // See: https://msdn.microsoft.com/en-us/library/1y71x448.aspx
     _CrtSetReportMode(_CRT_ASSERT, 0);
     // Disable dialog boxes for "critical" errors or when OpenFile cannot find
     // the requested file. See:
     // See: https://msdn.microsoft.com/en-us/library/windows/desktop/ms680621(v=vs.85).aspx
     SetErrorMode(SEM_FAILCRITICALERRORS | SEM_NOOPENFILEERRORBOX);
     // Set up a signal handler that restores the console state on a
     // CTRL_C_EVENT signal. This will only run when there is no signal handler
     // registered for the CTRL_C_EVENT from Dart code.
     SetConsoleCtrlHandler(SignalHandler, TRUE);
+#ifndef PRODUCT
+    // Set up global exception handler to be able to dump stack trace on crash.
+    SetExceptionHandler();
+#endif
   }
 
   static BOOL WINAPI SignalHandler(DWORD signal) {
     if (signal == CTRL_C_EVENT) {
       // We call this without taking the lock because this is a signal
       // handler, and because the process is about to go down.
       RestoreConsoleLocked();
     }
     return FALSE;
   }
@@ skipping 24 matching lines @@
     // TODO(28984): Due to issue #29104, we cannot set
     // ENABLE_VIRTUAL_TERMINAL_INPUT here, as it causes ENABLE_PROCESSED_INPUT
     // to be ignored.
   }
 
   static void RestoreConsole() {
     MutexLocker ml(platform_win_mutex_);
     RestoreConsoleLocked();
   }
 
+  static void SetExceptionHandler() {
+    SetUnhandledExceptionFilter(DartExceptionHandler);
+  }
+
  private:
   static Mutex* platform_win_mutex_;
   static int saved_output_cp_;
   static int saved_input_cp_;
 
   static void RestoreConsoleLocked() {
     // STD_OUTPUT_HANDLE and STD_INPUT_HANDLE may have been closed or
     // redirected. Therefore, we explicitly open the CONOUT$ and CONIN$
     // devices, so that we can be sure that we are really unsetting
     // ENABLE_VIRTUAL_TERMINAL_PROCESSING and ENABLE_VIRTUAL_TERMINAL_INPUT
@@ skipping 173 matching lines @@
   PlatformWin::RestoreConsole();
   // On Windows we use ExitProcess so that threads can't clobber the exit_code.
   // See: https://code.google.com/p/nativeclient/issues/detail?id=2870
   ::ExitProcess(exit_code);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // defined(HOST_OS_WINDOWS)