Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 2975973002: [LayoutNG] Refactor of HandleInflow children. (Closed)

Created:
3 years, 5 months ago by ikilpatrick
Modified:
3 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews, lchoi+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Refactor of HandleInflow children. This moves a bunch of code around and some additional comments. Before the code for handling an inflow element was a little difficult to follow. Now most of the code and complexities are inside HandleInflow. Functions which this calls are now relatively simple. BUG=635619 Review-Url: https://codereview.chromium.org/2975973002 Cr-Commit-Position: refs/heads/master@{#486260} Committed: https://chromium.googlesource.com/chromium/src/+/987ca52741e0e4f0399de57732e4afd2382871cc

Patch Set 1 #

Patch Set 2 : rebase. #

Patch Set 3 : moar comments. #

Patch Set 4 : \o/ #

Patch Set 5 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -110 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 1 2 chunks +15 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 3 13 chunks +106 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_fragment.h View 1 chunk +0 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (15 generated)
ikilpatrick
3 years, 5 months ago (2017-07-12 19:40:42 UTC) #9
eae
LGTM
3 years, 5 months ago (2017-07-12 19:46:01 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975973002/80001
3 years, 5 months ago (2017-07-12 20:54:31 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 03:44:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/987ca52741e0e4f0399de57732e4...

Powered by Google App Engine
This is Rietveld 408576698