Make ProfileURLRequestContexts use their own CTPolicyEnforcer.

Make ProfileURLRequestContexts use their own CTPolicyEnforcer.

This is mostly about making URLRequestContextBuilder creation simpler,
so the NetworkService doesn't have to worry about sharing
CTPolicyEnforcers between URLRequestContexts.

BUG=734199
Review-Url: https://codereview.chromium.org/2975903002
Cr-Commit-Position: refs/heads/master@{#485765}
Committed: https://chromium.googlesource.com/chromium/src/+/0c15ff49e64bda7efc4d6259296f1bcdca64039b

[mmenke, 2017-07-11 16:28:02]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-11 16:28:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-11 17:18:06]

mmenke@chromium.org changed reviewers:
+ estark@chromium.org

[mmenke, 2017-07-11 17:18:07]

There's no need to share CTPolicyEnforcers between URLRequestContexts, right?  I
want to make URLRequestContexts more self-contained when switching construction
over to the NetworkService (Sharing just NetLog, HostResolvers,
NetworkQualityEstimators, and maybe CertVerifiers)

https://codereview.chromium.org/2975903002/diff/1/chrome/browser/io_thread.cc
File chrome/browser/io_thread.cc (left):

https://codereview.chromium.org/2975903002/diff/1/chrome/browser/io_thread.cc...
chrome/browser/io_thread.cc:79: #include "net/cert/ct_policy_enforcer.h"
Not exactly related to the other changes, but this class no longer creates its
own CTPolicyEnforcer, and instead lets the URLRequestContextBuilder take care of
that.

[commit-bot: I haz the power, 2017-07-11 17:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-11 17:34:22]

Dry run: This issue passed the CQ dry run.

[estark, 2017-07-11 21:55:19]

lgtm, but it might be worth a quick sanity-check with sleevi; I'm not sure I
have all the context. I can't think of a reason that CTPolicyEnforcers need to
be shared. Just for my own understanding, the reason to share, say,
CertVerifiers among URLRequestContexts would be to share caching and such?

[mmenke, 2017-07-11 21:57:24]

On 2017/07/11 21:55:19, estark wrote:
> lgtm, but it might be worth a quick sanity-check with sleevi; I'm not sure I
> have all the context. I can't think of a reason that CTPolicyEnforcers need to
> be shared. Just for my own understanding, the reason to share, say,
> CertVerifiers among URLRequestContexts would be to share caching and such?

Yea, that's the reason why we might want to share CertVerifiers.  I'll add
sleevi.

[mmenke, 2017-07-11 21:59:15]

mmenke@chromium.org changed reviewers:
+ rsleevi@chromium.org

[mmenke, 2017-07-11 21:59:16]

[+rsleevi]:  PTAL.  This isn't too exciting, I'm just trying to reduce sharing
of URLRequestContext components before I start moving configuration over to the
NetworkService, to simplify configuration.

[Ryan Sleevi, 2017-07-11 22:02:31]

LGTM

The only reason is to reduce memory overhead, since all objects implement the
same behaviour.

[mmenke, 2017-07-11 22:06:00]

On 2017/07/11 22:02:31, Ryan Sleevi wrote:
> LGTM
> 
> The only reason is to reduce memory overhead, since all objects implement the
> same behaviour.

Thanks!  Seems small enough (Just a vtable pointer?) that it shouldn't matter
much, given that we only have a couple URLRequestContexts.

[mmenke, 2017-07-11 22:06:04]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-07-11 22:07:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-07-11 23:32:23]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-07-11 23:32:29]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-07-11 23:32:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-12 01:25:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499815949032030, "parent_rev":
"9e11581c14be9b15a9ac690d6a62483fbb92abd8", "commit_rev":
"0c15ff49e64bda7efc4d6259296f1bcdca64039b"}

[commit-bot: I haz the power, 2017-07-12 01:26:11]

Description was changed from

==========
Make ProfileURLRequestContexts use their own CTPolicyEnforcer.

This is mostly about making URLRequestContextBuilder creation simpler,
so the NetworkService doesn't have to worry about sharing
CTPolicyEnforcers between URLRequestContexts.

BUG=734199
==========

to

==========
Make ProfileURLRequestContexts use their own CTPolicyEnforcer.

This is mostly about making URLRequestContextBuilder creation simpler,
so the NetworkService doesn't have to worry about sharing
CTPolicyEnforcers between URLRequestContexts.

BUG=734199

Review-Url: https://codereview.chromium.org/2975903002
Cr-Commit-Position: refs/heads/master@{#485765}
Committed:
https://chromium.googlesource.com/chromium/src/+/0c15ff49e64bda7efc4d6259296f...
==========

[commit-bot: I haz the power, 2017-07-12 01:26:14]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0c15ff49e64bda7efc4d6259296f...