Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2975883003: Revert of Fixes redirects to external apps when navigating from PWA. (Closed)

Created:
3 years, 5 months ago by aberent
Modified:
3 years, 5 months ago
Reviewers:
dominickn, Ted C, Yusuf, piotrs
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixes redirects to external apps when navigating from PWA. (patchset #9 id:280001 of https://codereview.chromium.org/2969143002/ ) Reason for revert: Test failures from new test WebappNavigationTest#testNewTabLinkToExternalApp on hromium.android/Marshmallow 64 bit Tester. BUG=741568 Original issue's description: > Fixes the redirect to external apps when navigating from PWA. > > This is done with avoiding explicit chrome package name (using > component name instead) and using > EXTRA_SEND_TO_EXTERNAL_DEFAULT_HANDLER on the intent. > > With this patch the redirect works, however it takes a long time for CCT to > consult ExternalNavigationHandler. This results in suboptimal UX. Same redirect > in ChromeTabbedActivity is almost instantaneous. Result is that > for _blank links CCT shows up briefly before redirecting to an external app. > In a follow up it should be investigated why it is the case and if it cannot > be improved, we might need to bypass CCT in such case, which would diverge > from existing navigation paths for _blank links in Clank. > > BUG=740402 > > Review-Url: https://codereview.chromium.org/2969143002 > Cr-Commit-Position: refs/heads/master@{#485831} > Committed: https://chromium.googlesource.com/chromium/src/+/727468b41b2fe48bf73983ab0c3aa2632b47d89e TBR=dominickn@chromium.org,yusufo@chromium.org,tedchoc@chromium.org,piotrs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=740402 Review-Url: https://codereview.chromium.org/2975883003 Cr-Commit-Position: refs/heads/master@{#485910} Committed: https://chromium.googlesource.com/chromium/src/+/a1b6731c183e2273c3f3b013bf6db0bfe66fdb2f

Patch Set 1 #

Messages

Total messages: 6 (3 generated)
aberent
Created Revert of Fixes redirects to external apps when navigating from PWA.
3 years, 5 months ago (2017-07-12 10:03:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975883003/1
3 years, 5 months ago (2017-07-12 10:03:29 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 10:04:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a1b6731c183e2273c3f3b013bf6d...

Powered by Google App Engine
This is Rietveld 408576698