MD Extensions: Move MD only strings to their own grdp file.

MD Extensions: Move MD only strings to their own grdp file.

BUG=739964
Review-Url: https://codereview.chromium.org/2975713002
Cr-Commit-Position: refs/heads/master@{#485445}
Committed: https://chromium.googlesource.com/chromium/src/+/bdb5508af594cd0eba912fd2d46cfae0ae8a881e

[dpapad, 2017-07-08 01:09:20]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-08 01:09:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-07-08 01:17:14]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-07-08 01:17:28]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-08 01:17:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-07-08 01:28:18]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-08 01:28:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-08 02:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-08 02:36:35]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-07-10 20:49:53]

dpapad@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, thestig@chromium.org

[dpapad, 2017-07-10 20:49:55]

This is what separating the new MD Extensions string to their own file would
look like. I tried to measure any differences in build times, but could not
detect any, so I think this is more about what we think is more readable, easier
to maintain.

[Devlin, 2017-07-10 21:40:29]

If Lei's happy, I'm happy. :)

[Lei Zhang, 2017-07-10 21:44:08]

lgtm

https://codereview.chromium.org/2975713002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2975713002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:195: <if expr="enable_extensions">
No need for nested ifs. Just checking "enable_extensions" should be good enough,
since that's how it was before.

[Devlin, 2017-07-10 21:47:14]

(also lgtm)

[dpapad, 2017-07-10 22:16:03]

https://codereview.chromium.org/2975713002/diff/60001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2975713002/diff/60001/chrome/app/generated_re...
chrome/app/generated_resources.grd:195: <if expr="enable_extensions">
On 2017/07/10 at 21:44:08, Lei Zhang wrote:
> No need for nested ifs. Just checking "enable_extensions" should be good
enough, since that's how it was before.

Done.

[dpapad, 2017-07-10 22:16:26]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-07-10 22:16:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2975713002/#ps80001
(title: "Address comment.")

[commit-bot: I haz the power, 2017-07-10 22:16:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 23:36:32]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1499724986418000,
"parent_rev": "b66fb23e3749385c06d3ef36a21acb4d9c56c41c", "commit_rev":
"bdb5508af594cd0eba912fd2d46cfae0ae8a881e"}

[commit-bot: I haz the power, 2017-07-10 23:36:45]

Description was changed from

==========
MD Extensions: Move MD only strings to their own grdp file.

BUG=739964
==========

to

==========
MD Extensions: Move MD only strings to their own grdp file.

BUG=739964

Review-Url: https://codereview.chromium.org/2975713002
Cr-Commit-Position: refs/heads/master@{#485445}
Committed:
https://chromium.googlesource.com/chromium/src/+/bdb5508af594cd0eba912fd2d46c...
==========

[commit-bot: I haz the power, 2017-07-10 23:36:47]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/bdb5508af594cd0eba912fd2d46c...