Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2975663003: Print Preview: Fix followup issues for removing global JS functions (Closed)

Created:
3 years, 5 months ago by rbpotter
Modified:
3 years, 5 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Print Preview: Fix followup issues for removing global JS functions Some followup changes from https://codereview.chromium.org/2969383003/ BUG=717296 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2975663003 Cr-Commit-Position: refs/heads/master@{#485466} Committed: https://chromium.googlesource.com/chromium/src/+/6653e8838ed3875db9953972e39b9bbc59abee7e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M chrome/browser/resources/print_preview/data/destination_store.js View 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/data/invitation_store.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/preview_generator.js View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/previewarea/preview_area.js View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/webui/print_preview/print_preview_destination_search_test.js View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
rbpotter
3 years, 5 months ago (2017-07-08 03:14:27 UTC) #8
rbpotter
3 years, 5 months ago (2017-07-08 03:14:29 UTC) #9
dpapad
lgtm
3 years, 5 months ago (2017-07-10 22:47:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975663003/1
3 years, 5 months ago (2017-07-10 23:10:31 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-11 00:45:01 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6653e8838ed3875db9953972e39b...

Powered by Google App Engine
This is Rietveld 408576698