Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2975603002: Drop a "using namespace WTF" in V8CSSStyleDeclarationCustom.cpp (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-style_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop a "using namespace WTF" in V8CSSStyleDeclarationCustom.cpp global "using namespace WTF" causes compiler warnings in jumbo builds and in general extend the global namespace a lot which increases the risk of symbol conflicts. This patch changes a "using namespace WTF" to an explicit WTF::CopePointCompareLessThan. Review-Url: https://codereview.chromium.org/2975603002 Cr-Commit-Position: refs/heads/master@{#484938} Committed: https://chromium.googlesource.com/chromium/src/+/e249265b0a218077df83ce37c25e736575041387

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Daniel Bratell
bashi, can you please take a look? This is to not have to exclude this ...
3 years, 5 months ago (2017-07-07 13:37:03 UTC) #4
Yuki
LGTM.
3 years, 5 months ago (2017-07-07 13:44:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975603002/1
3 years, 5 months ago (2017-07-07 14:12:34 UTC) #9
haraken
LGTM
3 years, 5 months ago (2017-07-07 14:39:00 UTC) #10
commit-bot: I haz the power
3 years, 5 months ago (2017-07-07 15:43:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e249265b0a218077df83ce37c25e...

Powered by Google App Engine
This is Rietveld 408576698