[vr] Deny permission requests in VR mode

chrome/browser/permissions/permission_request_manager_unittest.cc

Index: chrome/browser/permissions/permission_request_manager_unittest.cc
diff --git a/chrome/browser/permissions/permission_request_manager_unittest.cc b/chrome/browser/permissions/permission_request_manager_unittest.cc
index 559ea5eb39b4c225b72815f4ee72388895e4a07a..68811eefe18a544f5a92bbdc1365404400af01d3 100644
--- a/chrome/browser/permissions/permission_request_manager_unittest.cc
+++ b/chrome/browser/permissions/permission_request_manager_unittest.cc
@@ -46,12 +46,29 @@ class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {
             GURL("http://www.youtube.com")) {}
   ~PermissionRequestManagerTest() override {}
 
+  class PermissionRequestManagerWrapper : public PermissionRequestManager {
+   public:
+    explicit PermissionRequestManagerWrapper(content::WebContents* web_contents)
+        : PermissionRequestManager(web_contents) {}
+    ~PermissionRequestManagerWrapper() override {}
+
+    void set_permission_requests_disabled(bool value) {
+      permission_requests_disabled_ = value;
+    }
+    bool PermissionRequestsDisabled() const override {
+      return permission_requests_disabled_;
+    }
+
+   private:
+    bool permission_requests_disabled_ = false;
+  };
+
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     SetContents(CreateTestWebContents());
     NavigateAndCommit(GURL("http://www.google.com"));
 
-    manager_.reset(new PermissionRequestManager(web_contents()));
+    manager_.reset(new PermissionRequestManagerWrapper(web_contents()));
     prompt_factory_.reset(new MockPermissionPromptFactory(manager_.get()));
   }
 
@@ -101,7 +118,7 @@ class PermissionRequestManagerTest : public ChromeRenderViewHostTestHarness {
   MockPermissionRequest iframe_request_same_domain_;
   MockPermissionRequest iframe_request_other_domain_;
   MockPermissionRequest iframe_request_mic_other_domain_;
-  std::unique_ptr<PermissionRequestManager> manager_;
+  std::unique_ptr<PermissionRequestManagerWrapper> manager_;
   std::unique_ptr<MockPermissionPromptFactory> prompt_factory_;
 };
 
@@ -643,3 +660,10 @@ TEST_F(PermissionRequestManagerTest, UMAForMergedDeniedBubble) {
           PermissionRequestType::PERMISSION_MEDIASTREAM_CAMERA),
       1);
 }
+
+TEST_F(PermissionRequestManagerTest, DisabledPermissionRequests) {
+  manager_->set_permission_requests_disabled(true);

[raymes, 2017/07/11 01:43:23]

I think it would be better to simulate VR being enabled, as in
PermissionManagerTest.SuppressPermissionRequests
(permission_manager_unittest.cc). That would avoid needing the virtual function
and test subclass.

+  manager_->AddRequest(&request1_);
+  EXPECT_FALSE(request1_.granted());
+  EXPECT_TRUE(request1_.finished());
+}