[vr] Deny permission requests in VR mode

chrome/browser/permissions/permission_request_manager_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 28 matching lines @@
                                     GURL("http://www.google.com/some/url")),
         iframe_request_other_domain_("iframe",
                                      PermissionRequestType::UNKNOWN,
                                      GURL("http://www.youtube.com")),
         iframe_request_mic_other_domain_(
             "iframe",
             PermissionRequestType::PERMISSION_MEDIASTREAM_MIC,
             GURL("http://www.youtube.com")) {}
   ~PermissionRequestManagerTest() override {}
 
+  class PermissionRequestManagerWrapper : public PermissionRequestManager {
+   public:
+    explicit PermissionRequestManagerWrapper(content::WebContents* web_contents)
+        : PermissionRequestManager(web_contents) {}
+    ~PermissionRequestManagerWrapper() override {}
+
+    void set_permission_requests_disabled(bool value) {
+      permission_requests_disabled_ = value;
+    }
+    bool PermissionRequestsDisabled() const override {
+      return permission_requests_disabled_;
+    }
+
+   private:
+    bool permission_requests_disabled_ = false;
+  };
+
   void SetUp() override {
     ChromeRenderViewHostTestHarness::SetUp();
     SetContents(CreateTestWebContents());
     NavigateAndCommit(GURL("http://www.google.com"));
 
-    manager_.reset(new PermissionRequestManager(web_contents()));
+    manager_.reset(new PermissionRequestManagerWrapper(web_contents()));
     prompt_factory_.reset(new MockPermissionPromptFactory(manager_.get()));
   }
 
   void TearDown() override {
     prompt_factory_.reset();
     manager_.reset();
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
   void Accept() {
@@ skipping 29 matching lines @@
   }
 
  protected:
   MockPermissionRequest request1_;
   MockPermissionRequest request2_;
   MockPermissionRequest request_mic_;
   MockPermissionRequest request_camera_;
   MockPermissionRequest iframe_request_same_domain_;
   MockPermissionRequest iframe_request_other_domain_;
   MockPermissionRequest iframe_request_mic_other_domain_;
-  std::unique_ptr<PermissionRequestManager> manager_;
+  std::unique_ptr<PermissionRequestManagerWrapper> manager_;
   std::unique_ptr<MockPermissionPromptFactory> prompt_factory_;
 };
 
 TEST_F(PermissionRequestManagerTest, SingleRequest) {
   manager_->AddRequest(&request1_);
   manager_->DisplayPendingRequests();
   WaitForBubbleToBeShown();
 
   EXPECT_TRUE(prompt_factory_->is_visible());
   ASSERT_EQ(prompt_factory_->request_count(), 1);
@@ skipping 521 matching lines @@
       PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
       static_cast<base::HistogramBase::Sample>(
           PermissionRequestType::PERMISSION_MEDIASTREAM_MIC),
       1);
   histograms.ExpectBucketCount(
       PermissionUmaUtil::kPermissionsPromptMergedBubbleDenied,
       static_cast<base::HistogramBase::Sample>(
           PermissionRequestType::PERMISSION_MEDIASTREAM_CAMERA),
       1);
 }
+
+TEST_F(PermissionRequestManagerTest, DisabledPermissionRequests) {
+  manager_->set_permission_requests_disabled(true);

[raymes, 2017/07/11 01:43:23]

I think it would be better to simulate VR being enabled, as in
PermissionManagerTest.SuppressPermissionRequests
(permission_manager_unittest.cc). That would avoid needing the virtual function
and test subclass.

+  manager_->AddRequest(&request1_);
+  EXPECT_FALSE(request1_.granted());
+  EXPECT_TRUE(request1_.finished());
+}