third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json - Issue 2975523002: DevTools: add console test helpers to new test runner & migrate a console test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json

Issue 2975523002: DevTools: add console test helpers to new test runner & migrate a console test (Closed)

Patch Set: cleanup Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/console_test_runner/ConsoleTestRunner.js ('K') | « third_party/WebKit/Source/devtools/front_end/console_test_runner/ConsoleTestRunner.js ('k') | third_party/WebKit/Source/devtools/front_end/elements_test_runner/ElementsTestRunner.js » ('j') | third_party/WebKit/Source/devtools/front_end/integration_test_runner/IntegrationTestRunner.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json

diff --git a/third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json b/third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json

index 3a9a7ccaddb30a08500a763ad10e4ff178a7b393..a277fc3a85e7dace98534aa33d5581818c2f31d0 100644

--- a/third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json

+++ b/third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json

@@ -3,7 +3,8 @@

"test_runner",

"integration_test_runner",

"console",

- "console_model"

+ "console_model",

+ "main"

luoe 2017/07/07 22:26:40 It seems unfortunate to add this dependency for ju

dgozman 2017/07/09 18:15:40 Perhaps, we can extract counters into module?

chenwilliam 2017/07/10 21:14:35 Extracted! Dgozman - working on a weekend?!

"scripts": [

"ConsoleTestRunner.js"