third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json - Issue 2975523002: DevTools: add console test helpers to new test runner & migrate a console test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/console_test_runner/module.json

Issue 2975523002: DevTools: add console test helpers to new test runner & migrate a console test (Closed)

Patch Set: cleanup Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {	1 {

2 "dependencies": [	2 "dependencies": [

3 "test_runner",	3 "test_runner",

4 "integration_test_runner",	4 "integration_test_runner",

5 "console",	5 "console",

6 "console_model"	6 "console_model",

	7 "main"
	luoe 2017/07/07 22:26:40 It seems unfortunate to add this dependency for ju It seems unfortunate to add this dependency for just 2 tests that use Main's error counters. dgozman 2017/07/09 18:15:40 Perhaps, we can extract counters into module? Show quoted text On 2017/07/07 22:26:40, luoe wrote: > It seems unfortunate to add this dependency for just 2 tests that use Main's > error counters. Perhaps, we can extract counters into module? chenwilliam 2017/07/10 21:14:35 Extracted! Dgozman - working on a weekend?! Show quoted text On 2017/07/09 18:15:40, dgozman_ooo (send to pfeldman) wrote: > On 2017/07/07 22:26:40, luoe wrote: > > It seems unfortunate to add this dependency for just 2 tests that use Main's > > error counters. > > Perhaps, we can extract counters into module? Extracted! Dgozman - working on a weekend?!
7 ],	8 ],

8 "scripts": [	9 "scripts": [

9 "ConsoleTestRunner.js"	10 "ConsoleTestRunner.js"

10 ]	11 ]

11 }	12 }

OLD	NEW