Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2975433002: Assert that we don't mix K and J elements (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Assert that we don't mix K and J elements - we did for BackendImpact, RuntimeTypesNeed, native classes. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/1c8cb51132f7244760a6c7344cd8e69cdb4ae861

Patch Set 1 #

Total comments: 8

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+398 lines, -186 lines) Patch
M pkg/compiler/lib/src/closure.dart View 5 chunks +6 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/frontend_strategy.dart View 4 chunks +24 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 17 chunks +50 lines, -78 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 3 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 4 chunks +7 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/elements.dart View 5 chunks +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_model/js_strategy.dart View 4 chunks +41 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 22 chunks +78 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kelements.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 4 chunks +12 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/kernel/native_basic_data.dart View 1 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 3 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/native/resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_strategy.dart View 6 chunks +16 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/graph_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/element_world_builder.dart View 4 chunks +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 8 chunks +16 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_builder.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 7 chunks +36 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/equivalence/check_functions.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 5 chunks +21 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 3 chunks +16 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-06 15:07:35 UTC) #2
Siggi Cherem (dart-lang)
lgtm, only nits https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/js_backend/backend.dart#newcode763 pkg/compiler/lib/src/js_backend/backend.dart:763: compiler.frontendStrategy.nativeBasicData, use the local variable you ...
3 years, 5 months ago (2017-07-06 18:14:00 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 1c8cb51132f7244760a6c7344cd8e69cdb4ae861 (presubmit successful).
3 years, 5 months ago (2017-07-07 08:59:10 UTC) #5
Johnni Winther
3 years, 5 months ago (2017-07-07 09:58:29 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:763:
compiler.frontendStrategy.nativeBasicData,
On 2017/07/06 18:14:00, Siggi Cherem (dart-lang) wrote:
> use the local variable you added above?

Done.

https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:770:
compiler.frontendStrategy.nativeBasicData,
On 2017/07/06 18:14:00, Siggi Cherem (dart-lang) wrote:
> ditto

Done.

https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/js_mod...
File pkg/compiler/lib/src/js_model/elements.dart (right):

https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/js_mod...
pkg/compiler/lib/src/js_model/elements.dart:263: const String jsElementPrefix =
'j:';
On 2017/07/06 18:14:00, Siggi Cherem (dart-lang) wrote:
> ha - I thought of suggesting this yesterday and discarded my comment... I
guess
> it arrived telepathically regardless :-)

:)

https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/native_basic_data.dart (right):

https://codereview.chromium.org/2975433002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/native_basic_data.dart:39: LibraryEntity library,
On 2017/07/06 18:14:00, Siggi Cherem (dart-lang) wrote:
> nit: delete trailing `,`

Done.

Powered by Google App Engine
This is Rietveld 408576698