Assert that we don't mix K and J elements

pkg/compiler/lib/src/js_backend/backend.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library js_backend.backend;
 
 import '../common.dart';
 import '../common/backend_api.dart'
     show ForeignResolver, NativeRegistry, ImpactTransformer;
 import '../common/codegen.dart' show CodegenWorkItem;
@@ skipping 347 matching lines @@
   final Set<ClassEntity> specialOperatorEqClasses = new Set<ClassEntity>();
 
   List<CompilerTask> get tasks {
     List<CompilerTask> result = functionCompiler.tasks;
     result.add(emitter);
     result.add(patchResolverTask);
     result.add(kernelTask);
     return result;
   }
 
-  final RuntimeTypesNeedBuilder _rtiNeedBuilder;
-  RuntimeTypesNeed _rtiNeed;
-  final RuntimeTypesImpl _rti;
+  RuntimeTypesImpl _rti;
 
   RuntimeTypesEncoder _rtiEncoder;
 
   /// True if the html library has been loaded.
   bool htmlLibraryIsLoaded = false;
 
-  /// Resolution analysis for tracking reflective access to type variables.
-  TypeVariableResolutionAnalysis _typeVariableResolutionAnalysis;
-
   /// Codegen handler for reflective access to type variables.
   TypeVariableCodegenAnalysis _typeVariableCodegenAnalysis;
 
   /// Resolution support for generating table of interceptors and
   /// constructors for custom elements.
   CustomElementsResolutionAnalysis _customElementsResolutionAnalysis;
 
   /// Codegen support for generating table of interceptors and
   /// constructors for custom elements.
   CustomElementsCodegenAnalysis _customElementsCodegenAnalysis;
@@ skipping 30 matching lines @@
 
   PatchResolverTask patchResolverTask;
 
   /// The strategy used for collecting and emitting source information.
   SourceInformationStrategy sourceInformationStrategy;
 
   /// Interface for serialization of backend specific data.
   JavaScriptBackendSerialization serialization;
 
   NativeDataBuilderImpl _nativeDataBuilder;
-  final NativeBasicDataBuilderImpl _nativeBasicDataBuilder =
-      new NativeBasicDataBuilderImpl();
-  NativeBasicDataImpl _nativeBasicData;
   NativeDataBuilder get nativeDataBuilder => _nativeDataBuilder;
   final NativeDataResolver _nativeDataResolver;
   OneShotInterceptorData _oneShotInterceptorData;
   BackendUsageBuilder _backendUsageBuilder;
   MirrorsDataImpl _mirrorsData;
   CheckedModeHelpers _checkedModeHelpers;
 
   final SuperMemberData superMemberData = new SuperMemberData();
 
   native.NativeResolutionEnqueuer _nativeResolutionEnqueuer;
   native.NativeCodegenEnqueuer _nativeCodegenEnqueuer;
 
-  BackendImpacts impacts;
-
   Target _target;
 
   Tracer tracer;
 
   JavaScriptBackend(this.compiler,
       {bool generateSourceMap: true,
       bool useStartupEmitter: false,
       bool useMultiSourceInfo: false,
       bool useNewSourceInfo: false,
       bool useKernel: false})
-      : _rti = new RuntimeTypesImpl(
-            compiler.frontendStrategy.elementEnvironment,
-            compiler.frontendStrategy.dartTypes),
-        optimizerHints = new OptimizerHintsForTests(
+      : optimizerHints = new OptimizerHintsForTests(
             compiler.frontendStrategy.elementEnvironment,
             compiler.frontendStrategy.commonElements),
         this.sourceInformationStrategy =
             compiler.backendStrategy.sourceInformationStrategy,
         constantCompilerTask = new JavaScriptConstantTask(compiler),
-        _nativeDataResolver = new NativeDataResolverImpl(compiler),
-        _rtiNeedBuilder =
-            compiler.frontendStrategy.createRuntimeTypesNeedBuilder() {
+        _nativeDataResolver = new NativeDataResolverImpl(compiler) {
     CommonElements commonElements = compiler.frontendStrategy.commonElements;
     _target = new JavaScriptBackendTarget(this);
-    impacts = new BackendImpacts(compiler.options, commonElements);
     _mirrorsData = compiler.frontendStrategy.createMirrorsDataBuilder();
     _backendUsageBuilder = new BackendUsageBuilderImpl(commonElements);
     _checkedModeHelpers = new CheckedModeHelpers(commonElements);
     emitter =
         new CodeEmitterTask(compiler, generateSourceMap, useStartupEmitter);
-
-    _typeVariableResolutionAnalysis = new TypeVariableResolutionAnalysis(
-        compiler.frontendStrategy.elementEnvironment,
-        impacts,
-        _backendUsageBuilder);
     jsInteropAnalysis = new JsInteropAnalysis(this);
     _mirrorsResolutionAnalysis =
         compiler.frontendStrategy.createMirrorsResolutionAnalysis(this);
     lookupMapResolutionAnalysis = new LookupMapResolutionAnalysis(
         reporter, compiler.frontendStrategy.elementEnvironment);
 
     noSuchMethodRegistry = new NoSuchMethodRegistry(
         commonElements, compiler.frontendStrategy.createNoSuchMethodResolver());
     kernelTask = new KernelTask(compiler);
     patchResolverTask = new PatchResolverTask(compiler);
@@ skipping 25 matching lines @@
   /// Codegen support for generating table of interceptors and
   /// constructors for custom elements.
   CustomElementsCodegenAnalysis get customElementsCodegenAnalysis {
     assert(
         _customElementsCodegenAnalysis != null,
         failedAt(NO_LOCATION_SPANNABLE,
             "CustomElementsCodegenAnalysis has not been created yet."));
     return _customElementsCodegenAnalysis;
   }
 
-  NativeBasicData get nativeBasicData {
-    assert(
-        _nativeBasicData != null,
-        failedAt(NO_LOCATION_SPANNABLE,
-            "NativeBasicData has not been computed yet."));
-    return _nativeBasicData;
-  }
-
-  NativeBasicDataBuilder get nativeBasicDataBuilder => _nativeBasicDataBuilder;
-
-  /// Resolution analysis for tracking reflective access to type variables.
-  TypeVariableResolutionAnalysis get typeVariableResolutionAnalysis {
-    assert(
-        _typeVariableCodegenAnalysis == null,
-        failedAt(NO_LOCATION_SPANNABLE,
-            "TypeVariableHandler has already been created."));
-    return _typeVariableResolutionAnalysis;
-  }
-
   /// Codegen handler for reflective access to type variables.
   TypeVariableCodegenAnalysis get typeVariableCodegenAnalysis {
     assert(
         _typeVariableCodegenAnalysis != null,
         failedAt(NO_LOCATION_SPANNABLE,
             "TypeVariableHandler has not been created yet."));
     return _typeVariableCodegenAnalysis;
   }
 
   MirrorsData get mirrorsData => _mirrorsData;
@@ skipping 23 matching lines @@
   }
 
   OneShotInterceptorData get oneShotInterceptorData {
     assert(
         _oneShotInterceptorData != null,
         failedAt(NO_LOCATION_SPANNABLE,
             "OneShotInterceptorData has not been prepared yet."));
     return _oneShotInterceptorData;
   }
 
-  RuntimeTypesNeed get rtiNeed {
+  RuntimeTypesChecksBuilder get rtiChecksBuilder {
     assert(
-        _rtiNeed != null,
+        _rti != null,
         failedAt(NO_LOCATION_SPANNABLE,
-            "RuntimeTypesNeed has not been computed yet."));
-    return _rtiNeed;
-  }
-
-  RuntimeTypesNeedBuilder get rtiNeedBuilder {
-    assert(
-        _rtiNeed == null,
-        failedAt(NO_LOCATION_SPANNABLE,
-            "RuntimeTypesNeed has already been computed."));
-    return _rtiNeedBuilder;
-  }
-
-  RuntimeTypesChecksBuilder get rtiChecksBuilder {
+            "RuntimeTypesChecksBuilder has not been created yet."));
     assert(
         !_rti.rtiChecksBuilderClosed,
         failedAt(NO_LOCATION_SPANNABLE,
             "RuntimeTypesChecks has already been computed."));
     return _rti;
   }
 
-  RuntimeTypesSubstitutions get rtiSubstitutions => _rti;
+  RuntimeTypesSubstitutions get rtiSubstitutions {
+    assert(
+        _rti != null,
+        failedAt(NO_LOCATION_SPANNABLE,
+            "RuntimeTypesSubstitutions has not been created yet."));
+    return _rti;
+  }
 
   RuntimeTypesEncoder get rtiEncoder {
     assert(
         _rtiEncoder != null,
         failedAt(NO_LOCATION_SPANNABLE,
             "RuntimeTypesEncoder has not been created."));
     return _rtiEncoder;
   }
 
   CheckedModeHelpers get checkedModeHelpers => _checkedModeHelpers;
@@ skipping 95 matching lines @@
 
     validateInterceptorImplementsAllObjectMethods(
         frontendStrategy.commonElements.jsInterceptorClass);
     // The null-interceptor must also implement *all* methods.
     validateInterceptorImplementsAllObjectMethods(
         frontendStrategy.commonElements.jsNullClass);
   }
 
   /// Called when the resolution queue has been closed.
   void onResolutionEnd() {
-    frontendStrategy.annotationProcesser
-        .processJsInteropAnnotations(nativeBasicData, nativeDataBuilder);
+    frontendStrategy.annotationProcesser.processJsInteropAnnotations(
+        frontendStrategy.nativeBasicData, nativeDataBuilder);
   }
 
   /// Called when the closed world from resolution has been computed.
   void onResolutionClosedWorld(
       ClosedWorld closedWorld, ClosedWorldRefiner closedWorldRefiner) {
     for (MemberEntity entity
         in compiler.enqueuer.resolution.processedEntities) {
       processAnnotations(closedWorld.elementEnvironment,
           closedWorld.commonElements, entity, closedWorldRefiner);
     }
     mirrorsDataBuilder.computeMembersNeededForReflection(
         compiler.enqueuer.resolution.worldBuilder, closedWorld);
-    _rtiNeed = rtiNeedBuilder.computeRuntimeTypesNeed(
-        compiler.enqueuer.resolution.worldBuilder,
-        closedWorld,
-        compiler.frontendStrategy.dartTypes,
-        enableTypeAssertions: compiler.options.enableTypeAssertions);
     mirrorsResolutionAnalysis.onResolutionComplete();
   }
 
   void onTypeInferenceComplete(GlobalTypeInferenceResults results) {
     noSuchMethodRegistry.onTypeInferenceComplete(results);
   }
 
   /// Called when resolving a call to a foreign function.
   native.NativeBehavior resolveForeignCall(Send node, Element element,
       CallStructure callStructure, ForeignResolver resolver) {
@@ skipping 24 matching lines @@
     }
     // No native behavior for this call.
     return null;
   }
 
   ResolutionEnqueuer createResolutionEnqueuer(
       CompilerTask task, Compiler compiler) {
     ElementEnvironment elementEnvironment =
         compiler.frontendStrategy.elementEnvironment;
     CommonElements commonElements = compiler.frontendStrategy.commonElements;
-    _nativeBasicData = nativeBasicDataBuilder.close(elementEnvironment);
+    NativeBasicData nativeBasicData = compiler.frontendStrategy.nativeBasicData;
+    RuntimeTypesNeedBuilder rtiNeedBuilder =
+        compiler.frontendStrategy.createRuntimeTypesNeedBuilder();
+    BackendImpacts impacts =
+        new BackendImpacts(compiler.options, commonElements);
+    TypeVariableResolutionAnalysis typeVariableResolutionAnalysis =
+        new TypeVariableResolutionAnalysis(
+            compiler.frontendStrategy.elementEnvironment,
+            impacts,
+            _backendUsageBuilder);
     _nativeResolutionEnqueuer = new native.NativeResolutionEnqueuer(
         compiler.options,
         elementEnvironment,
         commonElements,
         compiler.frontendStrategy.dartTypes,
         _backendUsageBuilder,
         compiler.frontendStrategy.createNativeClassFinder(nativeBasicData));
     _nativeDataBuilder = new NativeDataBuilderImpl(nativeBasicData);
     _customElementsResolutionAnalysis = new CustomElementsResolutionAnalysis(
         constantSystem,
@@ skipping 38 matching lines @@
             mirrorsResolutionAnalysis,
             typeVariableResolutionAnalysis,
             _nativeResolutionEnqueuer,
             compiler.deferredLoadTask,
             kernelTask),
         compiler.frontendStrategy.createResolutionWorldBuilder(
             nativeBasicData,
             _nativeDataBuilder,
             interceptorDataBuilder,
             _backendUsageBuilder,
+            rtiNeedBuilder,
+            _nativeResolutionEnqueuer,
             const OpenWorldStrategy()),
         compiler.frontendStrategy.createResolutionWorkItemBuilder(
             nativeBasicData, _nativeDataBuilder, impactTransformer));
   }
 
   /// Creates an [Enqueuer] for code generation specific to this backend.
   CodegenEnqueuer createCodegenEnqueuer(
       CompilerTask task, Compiler compiler, ClosedWorld closedWorld) {
     ElementEnvironment elementEnvironment = closedWorld.elementEnvironment;
     CommonElements commonElements = closedWorld.commonElements;
+    BackendImpacts impacts =
+        new BackendImpacts(compiler.options, commonElements);
     _typeVariableCodegenAnalysis = new TypeVariableCodegenAnalysis(
         closedWorld.elementEnvironment, this, commonElements, mirrorsData);
     _lookupMapAnalysis = new LookupMapAnalysis(
         reporter,
         constantSystem,
         constants,
         elementEnvironment,
         commonElements,
         lookupMapResolutionAnalysis);
     _mirrorsCodegenAnalysis = mirrorsResolutionAnalysis.close();
     _customElementsCodegenAnalysis = new CustomElementsCodegenAnalysis(
-        constantSystem, commonElements, elementEnvironment, nativeBasicData);
+        constantSystem,
+        commonElements,
+        elementEnvironment,
+        closedWorld.nativeData);
     _nativeCodegenEnqueuer = new native.NativeCodegenEnqueuer(
         compiler.options,
         elementEnvironment,
         commonElements,
-        compiler.frontendStrategy.dartTypes,
+        closedWorld.dartTypes,
         emitter,
-        _nativeResolutionEnqueuer,
+        closedWorld.liveNativeClasses,
         closedWorld.nativeData);
     return new CodegenEnqueuer(
         task,
         compiler.options,
         const TreeShakingEnqueuerStrategy(),
         compiler.backendStrategy.createCodegenWorldBuilder(
-            nativeBasicData, closedWorld, const TypeMaskStrategy()),
+            closedWorld.nativeData, closedWorld, const TypeMaskStrategy()),
         compiler.backendStrategy.createCodegenWorkItemBuilder(closedWorld),
         new CodegenEnqueuerListener(
             elementEnvironment,
             commonElements,
             impacts,
             closedWorld.backendUsage,
-            rtiNeed,
+            closedWorld.rtiNeed,
             customElementsCodegenAnalysis,
             typeVariableCodegenAnalysis,
             lookupMapAnalysis,
             mirrorsCodegenAnalysis,
             nativeCodegenEnqueuer));
   }
 
   WorldImpact codegen(CodegenWorkItem work, ClosedWorld closedWorld) {
     MemberEntity element = work.element;
     if (compiler.elementHasCompileTimeError(element)) {
@@ skipping 27 matching lines @@
         .transformCodegenImpact(work.registry.worldImpact);
     compiler.dumpInfoTask.registerImpact(element, worldImpact);
     return worldImpact;
   }
 
   native.NativeResolutionEnqueuer get nativeResolutionEnqueuerForTesting =>
       _nativeResolutionEnqueuer;
 
   native.NativeEnqueuer get nativeCodegenEnqueuer => _nativeCodegenEnqueuer;
 
-  ClassElement defaultSuperclass(
-      CommonElements commonElements, ClassElement element) {
+  ClassElement defaultSuperclass(CommonElements commonElements,
+      NativeBasicData nativeBasicData, ClassElement element) {
     if (nativeBasicData.isJsInteropClass(element)) {
       return commonElements.jsJavaScriptObjectClass;
     }
     // Native classes inherit from Interceptor.
     return nativeBasicData.isNativeClass(element)
         ? commonElements.jsInterceptorClass
         : commonElements.objectClass;
   }
 
   /**
@@ skipping 66 matching lines @@
         element == commonElements.jsUnmodifiableArrayClass;
   }
 
   /// This method is called immediately after the [library] and its parts have
   /// been loaded.
   void setAnnotations(LibraryEntity library) {
     if (!compiler.serialization.isDeserialized(library)) {
       AnnotationProcessor processor =
           compiler.frontendStrategy.annotationProcesser;
       if (canLibraryUseNative(library)) {
-        processor.extractNativeAnnotations(library, nativeBasicDataBuilder);
+        processor.extractNativeAnnotations(library);
       }
-      processor.extractJsInteropAnnotations(library, nativeBasicDataBuilder);
+      processor.extractJsInteropAnnotations(library);
     }
     Uri uri = library.canonicalUri;
     if (uri == Uris.dart_html) {
       htmlLibraryIsLoaded = true;
     } else if (uri == LookupMapResolutionAnalysis.PACKAGE_LOOKUP_MAP) {
       lookupMapResolutionAnalysis.init(library);
     }
   }
 
   /// This method is called when all new libraries loaded through
@@ skipping 17 matching lines @@
   WorldImpact onCodegenStart(ClosedWorld closedWorld,
       CodegenWorldBuilder codegenWorldBuilder, Sorter sorter) {
     functionCompiler.onCodegenStart();
     _oneShotInterceptorData = new OneShotInterceptorData(
         closedWorld.interceptorData, closedWorld.commonElements);
     _namer = determineNamer(closedWorld, codegenWorldBuilder);
     tracer = new Tracer(closedWorld, namer, compiler);
     _rtiEncoder = _namer.rtiEncoder = new RuntimeTypesEncoderImpl(
         namer, closedWorld.elementEnvironment, closedWorld.commonElements);
     emitter.createEmitter(namer, closedWorld, codegenWorldBuilder, sorter);
+    // TODO(johnniwinther): Share the impact object created in
+    // createCodegenEnqueuer.
+    BackendImpacts impacts =
+        new BackendImpacts(compiler.options, closedWorld.commonElements);
+    _rti = new RuntimeTypesImpl(
+        closedWorld.elementEnvironment, closedWorld.dartTypes);
     _codegenImpactTransformer = new CodegenImpactTransformer(
         compiler.options,
         closedWorld.elementEnvironment,
         closedWorld.commonElements,
         impacts,
         checkedModeHelpers,
         closedWorld.nativeData,
         closedWorld.backendUsage,
-        rtiNeed,
+        closedWorld.rtiNeed,
         nativeCodegenEnqueuer,
         namer,
         oneShotInterceptorData,
         lookupMapAnalysis,
         rtiChecksBuilder);
     return const WorldImpact();
   }
 
   /// Called when code generation has been completed.
   void onCodegenEnd() {
@@ skipping 267 matching lines @@
     return _backend.resolveForeignCall(node, element, callStructure, resolver);
   }
 
   @override
   bool isDefaultNoSuchMethod(MethodElement element) {
     return _commonElements.isDefaultNoSuchMethodImplementation(element);
   }
 
   @override
   ClassElement defaultSuperclass(ClassElement element) {
-    return _backend.defaultSuperclass(_commonElements, element);
+    return _backend.defaultSuperclass(
+        _commonElements, _backend.frontendStrategy.nativeBasicData, element);
   }
 
   @override
   bool isNativeClass(ClassEntity element) =>
-      _backend.nativeBasicData.isNativeClass(element);
+      _backend.compiler.frontendStrategy.nativeBasicData.isNativeClass(element);
 
   @override
   bool isForeign(Element element) =>
       _backend.isForeign(_commonElements, element);
 }
 
 class SuperMemberData {
   /// A set of member that are called from subclasses via `super`.
   final Set<MemberEntity> _aliasedSuperMembers = new Setlet<MemberEntity>();
 
@@ skipping 10 matching lines @@
 
   bool canUseAliasedSuperMember(MemberEntity member, Selector selector) {
     return !selector.isGetter;
   }
 
   /// Returns `true` if [member] is called from a subclass via `super`.
   bool isAliasedSuperMember(MemberEntity member) {
     return _aliasedSuperMembers.contains(member);
   }
 }