Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2975153002: Convert FILE thread usage in system_network_api.cc to TaskScheduler. (Closed)

Created:
3 years, 5 months ago by tapted
Modified:
3 years, 5 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert FILE thread usage in system_network_api.cc to TaskScheduler. BUG=689520 Review-Url: https://codereview.chromium.org/2975153002 Cr-Commit-Position: refs/heads/master@{#486625} Committed: https://chromium.googlesource.com/chromium/src/+/b49416e00e80161deee89efceaa0e8d6d9c602f8

Patch Set 1 #

Patch Set 2 : BLOCKING -> VISIBLE #

Total comments: 2

Patch Set 3 : GetListOnBlockingTaskRunner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -38 lines) Patch
M extensions/browser/api/system_network/system_network_api.h View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/system_network/system_network_api.cc View 1 2 2 chunks +28 lines, -35 lines 0 comments Download

Messages

Total messages: 19 (14 generated)
tapted
Hiya ben, please take a look. (tested with extensions_unittests --gtest_filter=SystemNetworkApiUnitTest.* extensions_browsertests --gtest_filter=SystemNetworkApiTest.*
3 years, 5 months ago (2017-07-13 07:22:38 UTC) #4
benwells
lgtm withanit https://codereview.chromium.org/2975153002/diff/20001/extensions/browser/api/system_network/system_network_api.cc File extensions/browser/api/system_network/system_network_api.cc (right): https://codereview.chromium.org/2975153002/diff/20001/extensions/browser/api/system_network/system_network_api.cc#newcode12 extensions/browser/api/system_network/system_network_api.cc:12: std::unique_ptr<net::NetworkInterfaceList> GetListOnFileThread() { Nit: rename to something ...
3 years, 5 months ago (2017-07-13 08:24:30 UTC) #7
tapted
Thanks ben! https://codereview.chromium.org/2975153002/diff/20001/extensions/browser/api/system_network/system_network_api.cc File extensions/browser/api/system_network/system_network_api.cc (right): https://codereview.chromium.org/2975153002/diff/20001/extensions/browser/api/system_network/system_network_api.cc#newcode12 extensions/browser/api/system_network/system_network_api.cc:12: std::unique_ptr<net::NetworkInterfaceList> GetListOnFileThread() { On 2017/07/13 08:24:30, benwells ...
3 years, 5 months ago (2017-07-13 23:57:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975153002/40001
3 years, 5 months ago (2017-07-13 23:58:51 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 01:58:36 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b49416e00e80161deee89efceaa0...

Powered by Google App Engine
This is Rietveld 408576698