Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2975133004: Reland of [tracing] Add heap profiler perftests. (Closed)

Created:
3 years, 5 months ago by DmitrySkiba
Modified:
3 years, 5 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of [tracing] Add heap profiler perftests. > Reason for revert: > This broke Win 64: > https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder%20%28dbg%29&number=56316 > > Original issue's description: > > [tracing] Add heap profiler perftests. > > > > This CL creates a generic place for heap profiler perftests, and adds > > couple of stack frame deduplicator related perftests. > > > > BUG=739378 > > > > Review-Url: https://codereview.chromium.org/2976843002 > > Cr-Commit-Position: refs/heads/master@{#486544} > > Committed: https://chromium.googlesource.com/chromium/src/+/f43d398eac5c9d4c2bccda6d2630d108bbed1c99 > > TBR=primiano@chromium.org,dskiba@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=739378 > > Review-Url: https://codereview.chromium.org/2981833002 > Cr-Commit-Position: refs/heads/master@{#486555} TBR=primiano@chromium.org BUG=739378 Review-Url: https://codereview.chromium.org/2975133004 Cr-Commit-Position: refs/heads/master@{#486744} Committed: https://chromium.googlesource.com/chromium/src/+/484350a921288d2f41c025e7c114924d85007951

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -0 lines) Patch
M components/tracing/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A components/tracing/test/heap_profiler_perftest.cc View 1 1 chunk +159 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975133004/20001
3 years, 5 months ago (2017-07-14 12:29:19 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 12:32:58 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/484350a921288d2f41c025e7c114...

Powered by Google App Engine
This is Rietveld 408576698