Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2975133002: Make String16 consturctors non-inline to save binary size (150kb) (Closed)

Created:
3 years, 5 months ago by agrieve
Modified:
3 years, 5 months ago
Reviewers:
kozy
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Make String16 consturctors non-inline to save binary size (150kb) BUG=chromium:738469 Review-Url: https://codereview.chromium.org/2975133002 Cr-Commit-Position: refs/heads/master@{#46690} Committed: https://chromium.googlesource.com/v8/v8/+/8089fb9805190c85b637c1da209a35ce511004ab

Patch Set 1 #

Patch Set 2 : Make String16 consturctors non-inline to save binary size (150kb) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -26 lines) Patch
M src/inspector/string-16.h View 1 chunk +11 lines, -26 lines 0 comments Download
M src/inspector/string-16.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
agrieve
🏓
3 years, 5 months ago (2017-07-12 23:58:57 UTC) #2
kozy
lgtm, thanks!
3 years, 5 months ago (2017-07-13 00:08:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2975133002/20001
3 years, 5 months ago (2017-07-17 01:13:18 UTC) #5
commit-bot: I haz the power
3 years, 5 months ago (2017-07-17 01:39:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/8089fb9805190c85b637c1da209a35ce511...

Powered by Google App Engine
This is Rietveld 408576698